From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932163AbbFEEyB (ORCPT ); Fri, 5 Jun 2015 00:54:01 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:48188 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752339AbbFEEx7 (ORCPT ); Fri, 5 Jun 2015 00:53:59 -0400 X-AuditID: cbfee691-f79ca6d00000456a-c6-55712b643c7d Message-id: <55712B64.3090205@samsung.com> Date: Fri, 05 Jun 2015 13:53:56 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Jaewon Kim Cc: MyungJoo Ham , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH] extcon: max77843: Clear IRQ bits state before request IRQ References: <1433478747-12254-1-git-send-email-jaewon02.kim@samsung.com> In-reply-to: <1433478747-12254-1-git-send-email-jaewon02.kim@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42JZI2JSqJuiXRhqcOqGvsWOhiOsFpd3zWGz mHF+H5PF7cYVbA4sHn1bVjF6fN4kF8AUxWWTkpqTWZZapG+XwJXx6+EBloIWroqfl/ayNDBO 5ehi5OSQEDCROLV9BSuELSZx4d56ti5GLg4hgaWMEp8/v2CGKbp7dxorRGI6o8S+80+YIJwH jBIP125l7GLk4OAV0JK42qEH0sAioCrxdsEUdhCbDSi8/8UNNhBbVCBMYuX0KywgNq+AoMSP yffAbBEBTYkjR44wgtjMAnkS6/a0gNULC/hJzFw1iQnEFhLwkPh0YxNYnFPAU6Lh6S0miHod if2t09ggbHmJzWveMoPcJiGwjF2ieeN/doiDBCS+TT7EAnKnhICsxKYDUI9JShxccYNlAqPY LCQnzUIydhaSsQsYmVcxiqYWJBcUJ6UXmeoVJ+YWl+al6yXn525iBMbO6X/PJu5gvH/A+hCj AAejEg/vg8P5oUKsiWXFlbmHGE2BrpjILCWanA+M0LySeENjMyMLUxNTYyNzSzMlcV4d6Z/B QgLpiSWp2ampBalF8UWlOanFhxiZODilGhilJ1m9fjB7TdoxhxDVo7/le+6KlG0Liwz5Ivy6 fovyWbeUg7XlO2pqZ/+3KAg79Cn5hsXbConFgisef+DNvrZCRCUjedWUySobtBdoPtt/fq2L wuNGJ+GZ1Zl77LoX6GY8PWc3scB0rmPz5XeuE7/sviXLui7Wbm1s5xeZExt9Hxc3L+Y5UXpY iaU4I9FQi7moOBEAs/h385gCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsVy+t9jQd0U7cJQg2lt2hY7Go6wWlzeNYfN Ysb5fUwWtxtXsDmwePRtWcXo8XmTXABTVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGh rqGlhbmSQl5ibqqtkotPgK5bZg7QJiWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1G BmggYQ1jxq+HB1gKWrgqfl7ay9LAOJWji5GTQ0LAROLu3WmsELaYxIV769m6GLk4hASmM0rs O/+ECcJ5wCjxcO1Wxi5GDg5eAS2Jqx16IA0sAqoSbxdMYQex2YDC+1/cYAOxRQXCJFZOv8IC YvMKCEr8mHwPzBYR0JQ4cuQII4jNLJAnsW5PC1i9sICfxMxVk5hAbCEBD4lPNzaBxTkFPCUa nt5igqjXkdjfOo0NwpaX2LzmLfMERoFZSFbMQlI2C0nZAkbmVYyiqQXJBcVJ6blGesWJucWl eel6yfm5mxjBkflMegfjqgaLQ4wCHIxKPLwWx/JDhVgTy4orcw8xSnAwK4nwavEUhgrxpiRW VqUW5ccXleakFh9iNAWGwERmKdHkfGDSyCuJNzQ2MTOyNDI3tDAyNlcS5z2Z7xMqJJCeWJKa nZpakFoE08fEwSnVwLj6Ub6L9iTz9VcMF9ytfmNRpLV+9/tLS+5n3F46Q9GE6e+K8zMaig/t PuYuuODhfPsNlpc73N3YVm/v9wzZGhJpwHzXpeCikaOPw+WJK30+H+BY81FhkW3d/m+nH55m Y5nvcHXDD/k+9qIyX6bTH7cdkvWMkLw7KzkhzCVvFrsF6yLVek4NmzwlluKMREMt5qLiRADK jAGE4gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaewon, On 06/05/2015 01:32 PM, Jaewon Kim wrote: > IRQ signal before driver probe is needless because driver sends > current state after platform booting done. > So, this patch clears MUIC IRQ bits before request IRQ. > > Signed-off-by: Jaewon Kim > --- > drivers/extcon/extcon-max77843.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c > index d78a64d..11e09d1 100644 > --- a/drivers/extcon/extcon-max77843.c > +++ b/drivers/extcon/extcon-max77843.c > @@ -781,6 +781,15 @@ static int max77843_muic_probe(struct platform_device *pdev) > /* Support virtual irq domain for max77843 MUIC device */ > INIT_WORK(&info->irq_work, max77843_muic_irq_work); > > + /* Clear IRQ bits before request IRQs */ > + ret = regmap_bulk_read(max77843->regmap_muic, > + MAX77843_MUIC_REG_INT1, info->status, > + MAX77843_MUIC_IRQ_NUM); > + if (ret) { > + dev_err(&pdev->dev, "Failed to Clear IRQ bits\n"); > + goto err_muic_irq; > + } > + > for (i = 0; i < ARRAY_SIZE(max77843_muic_irqs); i++) { > struct max77843_muic_irq *muic_irq = &max77843_muic_irqs[i]; > unsigned int virq = 0; > Applied it. Thanks, Chanwoo Choi