From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932592AbbFEGdA (ORCPT ); Fri, 5 Jun 2015 02:33:00 -0400 Received: from va-smtp01.263.net ([54.88.144.211]:38802 "EHLO va-smtp01.263.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751392AbbFEGcs (ORCPT ); Fri, 5 Jun 2015 02:32:48 -0400 X-RL-SENDER: kever.yang@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: kever.yang@rock-chips.com X-UNIQUE-TAG: <816b598e3505562b2f140950986a8377> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5571427B.1040406@rock-chips.com> Date: Fri, 05 Jun 2015 14:32:27 +0800 From: Kever Yang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Caesar Wang , Heiko Stuebner CC: Russell King , Dmitry Torokhov , dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] ARM: rockchip: ensure CPU to enter WIF state References: <1433479677-18086-1-git-send-email-wxt@rock-chips.com> <1433479677-18086-3-git-send-email-wxt@rock-chips.com> In-Reply-To: <1433479677-18086-3-git-send-email-wxt@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Caesar, Subject typo WIF/WFI. On 06/05/2015 12:47 PM, Caesar Wang wrote: > In idle mode, core1/2/3 of Cortex-A17 should be either power off or in > WFI/WFE state. > we can delay 1ms to ensure the CPU enter WFI state. > > Signed-off-by: Caesar Wang > --- > > arch/arm/mach-rockchip/platsmp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c > index 1230d3d..978c357 100644 > --- a/arch/arm/mach-rockchip/platsmp.c > +++ b/arch/arm/mach-rockchip/platsmp.c > @@ -316,6 +316,9 @@ static void __init rockchip_smp_prepare_cpus(unsigned int max_cpus) > #ifdef CONFIG_HOTPLUG_CPU > static int rockchip_cpu_kill(unsigned int cpu) > { > + /* ensure CPU can enter the WFI/WFE state */ > + mdelay(1); > + Does it matter if core is not in WFI state when we want to power down it? Thanks, - Kever > pmu_set_power_domain(0 + cpu, false); > return 1; > }