public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Taichi Kageyama <t-kageyama@cp.jp.nec.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"jslaby@suse.cz" <jslaby@suse.cz>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"prarit@redhat.com" <prarit@redhat.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: [PATCH 0/2] serial: 8250: Workaround to avoid irq=0 for console
Date: Fri, 5 Jun 2015 09:55:48 +0000	[thread overview]
Message-ID: <55717224.9060104@cp.jp.nec.com> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2161 bytes --]

This patch set provides a workaround to avoid the following problem.
It's based on Linux 4.1-rc3 mainstream kernel.
I've tested this patch set on x86-64 machine and KVM.

Problem
--------------------------
There're cases where autoconfig_irq() fails during boot.
In these cases, the console doesn't work in interrupt mode,
the mode cannot be changed anymore, and "input overrun"
(which can make operation mistakes) happens easily.
This problem happens with high rate every boot once it occurs
because the boot sequence is always almost same.
I saw the original problem on RHEL6.6.

Fix
--------------------------
serial: 8250: Fix autoconfig_irq() to avoid race conditions
  Fix one of autoconfig_irq() failure case.
serial: 8250: Allow to skip autoconfig_irq() for a console
  Provide a workaround to avoid other autoconfig_irq() failure cases.

Conditions of Reproduction
--------------------------
- Build with CONFIG_SERIAL_8250_DETECT_IRQ.
- Need non-PnP console serial or PnP console with no CONFIG_SERIAL_8250_PNP
- Kick printk() repeatedly on the CPU which can handle an interrupt
   from a console serial during autoconfig_irq(). The CPU is basically cpu0.
- Disable the interrupt of the CPU for longer during autoconfig_irq().

Note
--------------------------
Ideally, I think autoconfig_irq() should be fixed completely,
but it's hard from the following points
as long as auto_irq algorithm is used.
  - How long it should wait for an interrrupt
  - How to assure the interrupt of the CPU enabled during auto_irq
  - How to know which CPU can handle an interrupt from a serial.

Do you have any other idea?
In my opinion, providing a workaround is better than
applying big changes to the old function for legacy devices.

Taichi Kageyama (2):
   serial: 8250: Fix autoconfig_irq() to avoid race conditions
   serial: 8250: Allow to skip autoconfig_irq() for a console

  drivers/tty/serial/8250/8250_core.c |   23 +++++++++++++++++++++++
  1 files changed, 23 insertions(+), 0 deletions(-)
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

             reply	other threads:[~2015-06-05 10:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  9:55 Taichi Kageyama [this message]
2015-06-05  9:57 ` [PATCH 1/2] serial: 8250: Fix autoconfig_irq() to avoid race conditions Taichi Kageyama
2015-07-08 23:35   ` Peter Hurley
2015-07-23 22:32   ` gregkh
2015-07-29  8:13     ` Taichi Kageyama
2015-06-05 10:03 ` [PATCH 2/2] serial: 8250: Allow to skip autoconfig_irq() for a console Taichi Kageyama
2015-07-08 11:55   ` Peter Hurley
2015-07-08 12:53     ` Prarit Bhargava
2015-07-08 13:51       ` Peter Hurley
2015-07-08 14:00         ` Prarit Bhargava
2015-07-09  5:32           ` Taichi Kageyama
2015-07-11  0:12             ` Peter Hurley
2015-07-14  1:16               ` Taichi Kageyama
2015-07-14 19:29                 ` Peter Hurley
2015-07-16  9:58                   ` Taichi Kageyama
2015-07-20 16:36                     ` Peter Hurley
2015-07-21  9:44                       ` Taichi Kageyama
2015-07-27 19:44                         ` Peter Hurley
2015-07-29  8:09                           ` Taichi Kageyama
2015-07-07  8:13 ` [PATCH 0/2] serial: 8250: Workaround to avoid irq=0 for console Taichi Kageyama
2015-07-07 22:42   ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55717224.9060104@cp.jp.nec.com \
    --to=t-kageyama@cp.jp.nec.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox