From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932664AbbFEN5j (ORCPT ); Fri, 5 Jun 2015 09:57:39 -0400 Received: from mail-by2on0058.outbound.protection.outlook.com ([207.46.100.58]:51863 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932478AbbFEN5f (ORCPT ); Fri, 5 Jun 2015 09:57:35 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; gmail.com; dkim=none (message not signed) header.d=none; Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none; Message-ID: <5571AAB3.2000005@opensource.altera.com> Date: Fri, 5 Jun 2015 08:57:07 -0500 From: Dinh Nguyen User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Borislav Petkov CC: Thor Thayer , , , , , , , , , , , , , , , Subject: Re: [PATCHv2 2/4] edac, altera: Refactor EDAC for Altera CycloneV SoC. References: <1433428128-7292-1-git-send-email-tthayer@opensource.altera.com> <1433428128-7292-3-git-send-email-tthayer@opensource.altera.com> <55706E25.8050105@opensource.altera.com> <5570C479.7010902@opensource.altera.com> <20150604220609.GK3795@pd.tnic> <5570D0D0.9030803@opensource.altera.com> <20150605091731.GA3679@pd.tnic> In-Reply-To: <20150605091731.GA3679@pd.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [99.103.66.154] X-ClientProxiedBy: BLUPR16CA0011.namprd16.prod.outlook.com (25.164.14.21) To BLUPR03MB1364.namprd03.prod.outlook.com (25.163.80.30) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1364;2:Of7cFFkqqAFhNQrMJdi8bgGUkhMVsjuDwpMeDOt7HF5i8L1OEf9PlR2GRQNBANA3;2:qxZPoWQ5y2EcInXi1oN3G1TmSR/bL8WKy4nFUZckxIapX1TGZcjiYc1bh07z9MH9PFtURxboZhhCTRAxJ27fc2wkJdbr36e6r8X+91enJE0MrheEFPK9XV8WSOa8NRmaLNOt4/L9Q++kB+K3sPuwng==;6:nJmjrIV9Ln5eP1sOFApwV+tv8Ee8picoZLz9EoIgPp1zZ77CkMRFapfdbncilJQMkrRJbvC5sXhc134TW8ksXo4z129tuJUCFCfUfJ/nQhFCHKaXK9jSiS1D/Uyd0V8Ln8bzqClhVkWD0jOHsf7xeQ==;3:twGFdNc10MTYSacwWRg8TpA61Vr0qGcGQnwXaK+xEMCabND/EH093v9coZnt416Xar+2daznUigg0Q0I2BJXlIyWk6QVnEOE4Rkh6CGM7dqfltZWQSQvVUtqVZ3xESKibZn23qxbf7cIG6kga6O5eNgaxVElOqGd9jSeOv4uvuSLH2Hro/ez8sMnf4sfWegnWgUKUHC2fCi3oy9cuz5uvC8qm4ALX0eYoryjUtge2bsH01DsdXvskIY3iWC53t4x1EKJZk9+uLPm56UdBvHUusaAXH8pIlxe+olpTnqF9Fefr3CpFkSGQIrTDXAjwKe1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1364;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB119; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:BLUPR03MB1364;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1364;BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:BLUPR03MB119;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB119; X-Forefront-PRVS: 05986C03E0 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(51704005)(377454003)(24454002)(164054003)(479174004)(65816999)(19580395003)(23676002)(42186005)(19580405001)(50466002)(86362001)(54356999)(87266999)(83506001)(50986999)(87976001)(76176999)(59896002)(40100003)(77156002)(122386002)(62966003)(93886004)(4001350100001)(15975445007)(77096005)(2950100001)(47776003)(66066001)(5001920100001)(33656002)(65956001)(92566002)(189998001)(110136002)(46102003)(5001960100002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1364;H:Dinhs-MacBook-Pro.local;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?utf-8?B?MTtCTFVQUjAzTUIxMzY0Ozk6MjIyU21mTHB5MThPY0txSkZHNEFIOWF1b3lH?= =?utf-8?B?WWVzcVpCQmJXWmJ6NmJzb1dwOUJybXcxWGFEOWUzZk9vejBobm1zNmt0Rk1z?= =?utf-8?B?MmlxSGl5ZXRkTWo3Z3RnbEJRRDRyNzljUGJ3ZFBRSlNtajkrVmVsVFBQNmlZ?= =?utf-8?B?K2F2QnJORVhKcWI5RFZkRXFqeXZCdzkvcDYwN2x5WTBLa0cyMFdNTDZ3QXpZ?= =?utf-8?B?VHFJcFhSOXEwUW93T2xpQ0M4WnF5cFdEUVozMjNiRXdYT1BuRHRmNU13MkdJ?= =?utf-8?B?NkJLb3VVN3pFSDFSWkhEakkxdEdkRVhoaFhOS2ZPRUMxc3o3SExkemlKM0V6?= =?utf-8?B?bXZMYWpqazNVV2I3TW84eFBEV2JpU2dzT1BrZitRQXVBZjNJQlB0cDVFVmdC?= =?utf-8?B?V3N1ZGVYQmNUd2h1QnhucCtxbmRQeldXSExSVWtva2hVaUNNMDkvTWNUWWJS?= =?utf-8?B?UTVTbmtCMTdGZzdleURIS085YnVkbGg3UHA2SmRmQzJkM2N1cG4rdjdaQWNH?= =?utf-8?B?T1d6VVRBUVB2NHgvalBkZ3FwOFBCQW1LZVJrQTQ0dmtjckJ2Vy85aVRVTVJF?= =?utf-8?B?a3dLS2I4RmlsVjMvN25nSUJIZTFIN3FmVnJPeUE3Z3Z0LzVoL1dvSHNvMWln?= =?utf-8?B?b2xhQ3Z3Vy9lK1NHZ0FlZTJrRkdLV3A5eGU5Ylkzb3c4NDdZQXNmVldpWDYz?= =?utf-8?B?VHFLOVR5N3BzNkJvNGkzVHFEbjlUSC9kS0xJcDdsWmJyTzAwOTV4TkpNb1pB?= =?utf-8?B?cFFGRWhmYTBodEYwVUUvdUp0R0NDbElzVXoyWFdNREt6NitDcWIzdkFiV1Ur?= =?utf-8?B?cTUyYXZ1YUtYcjl3enVMa2tpbldMWElYTklRU2tvQi9SRXhUdUlpYnQrQnlk?= =?utf-8?B?a2xYVjR4QnNsQm9rTUk4K0ovUmM4cE5ibXMyUUNUMG1pNFJqcC9NbVNud3VM?= =?utf-8?B?aUdXVVl1ZXFPa3pCdVFUV0JuYjBJa0w1UHNxbGtUdCtHRk5HdzNXOGNPNS93?= =?utf-8?B?THJmaDhzQStQTWsyOGkwckp2ZC9QSEhqMVgrRGRYaVhrb1BKUGY2SkpPMmxq?= =?utf-8?B?MElFMWpaaXdZT1p5bGZ1VXpuY21QRDNOT1UzUDZaRXhSakFtZ3g4WTVUelAw?= =?utf-8?B?VHFzMTZHdVZpak5OdlF3clRyYVcySUJQTWtLbFBCTVMyb1hBSDVBNG9QeENa?= =?utf-8?B?b3UwRHJPZFNKSzVoSHd0NFhaV3JHNVhiTTJ2aHFyMnRuUFJWemp2bzZiUEhN?= =?utf-8?B?YzdmSlFpaFppbnJSaEhGUU0zRmM0MDBWQlNWL2x6Um1yZHptRHZTSDg2RGF5?= =?utf-8?B?VFdGYTZMTDZMUXlEUTZIMHdKUTlvdjFMZjdIdzl2MlZqRUZNaDFKY2d1UlNz?= =?utf-8?B?dVRVZFhMOFp0a2wvbXcvK1dZU2FJMHUzQlZQck5hOVVUaHYxMEUzVXB3ekRN?= =?utf-8?Q?rZS6I=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1364;3:PTyJpW0fBTbgk8ffAFsG+5MrVOXQx53WHI53KBpoWr9E5+lftgMfMO1AkSCrNI9tyKOk3WTk+SdYNtU4hmsWXlolCpXoHl6N/ZuIXQdnUHQYK0GtKMabcRPEvtsWRl4VHn+WTmS2fyolWAY69iNQPw==;10:aUrksY651yLvxjpdgXTnthjElg1Sl6Zr+0McikNN6TGm80m6ksBFTalQXpawMAP6P1dYmbTtrhQlMBCCZ7+xwoIGvMu+QtfBjqtm8gWUeac=;6:22HDRB8njEBmucTbR7ch8ThibXqq/Rs+bwRSSbgWr19H+A2mCjg5WWYD7inNGRBw2oXll0anZS3tiPjeiRlm5wkdrxYIbzdU/taFKCBbblsyXdPkWpoQqSpyhEtPcnahtpBnoan1pFuDe2ut6n4Bmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1364 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BL2FFO11OLC008.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC008;1:UG/fPY5r+2KLARdH4oPGM5/WuJ4N7hLnhC+oRcS7SGM+TlV+z8CoIQJav6DdlQTOlAMfzU0uxRmgD2RwUB8tOnNqmdkghK62Bnw+zSLboymPGtJR5haOyIX3cXQ9MpyNfw9jALsSD6XCZmSxIMjpEWWnvOUOgLXaplL3/E1VvOCbRsFU/uQW8yjOdK+O6x5Lg7ZUVOKHFcOFv0HLX8U4773Ls+5GhfYkM/kV8DpaP5uGJg3+VvzrqQJk7SxCv5Q7MT3XmqtnV6PBPteXIk1sUnLgm0SIlGOJwRJUqf9dolYNRIAFQlsmY/CpohCxfG030Ea/GMI/wM3sVriqniEabKE6eNA3e3/s8TKae1EEP/0= X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(164054003)(377454003)(24454002)(199003)(479174004)(189002)(51704005)(50986999)(54356999)(76176999)(86362001)(40100003)(15975445007)(66066001)(87266999)(65816999)(189998001)(122386002)(6806004)(80316001)(19580395003)(62966003)(77156002)(85426001)(59896002)(87936001)(2950100001)(19580405001)(47776003)(92566002)(93886004)(83506001)(65956001)(77096005)(50466002)(106466001)(33656002)(46102003)(4001350100001)(5001920100001)(110136002)(64126003)(105606002)(65806001)(16796002)(23676002)(5001960100002)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB119;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:ovrnspm;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB119;2:AcoOiLvS6r5J8YvVeRBOfj8jmKN3azDg4JFxMtXt+/R9GDYcSCgJgO6KhOYkpEvY;2:qCEn1E0q85PESx7X7lep4JvhNCcCccEa8HnsMvfH38fP43Vcx0AYwxdwcGjvFL5YDwGb++PdgXcPksr3W1CoxWieeik5cNmWDall5ccfV5IaSTvoF3RvIcDTg+WzMb1zTyCOABDWLuy1gUuh3AVyFvzVTqzLlljP6Uj3PAEhNhvOnCC079dnjWg7RWWqLWX5kt81eh4NGeXcQ0quYpLlvN03PCoWPmXZMyjLL5ScSN8=;6:EpFUfUsRZUMQLaH4+6qCJPLEO8XejHyBoDwhBJ8OVnOZ1MtwE5/0VIFSC5fk6s0NdKPdAeUnU9JxIVsVKO8lm42MzXxBg+Haml4Qz7NFRmamJ5hwYO0Miyhp8QDrSb9OKSckZN/4iOYBsCzwhxWssA==;3:IO9fBTiYy2XQj3KmsZUds4vBVEJ3L51MwK3st6V0U0JRhx8lSmo/wKOq8g8vtoHRUO35YSNZotBjhifvfjB30Cdgv5+jSkEWZbRTk5dOp9E0huF9YBLXijfrDHoxVoKRkZlC0pm1rDZAVMie3iss7teAm4oBhK9ruEk3xA7rtGKGuN6HDZBhhW63MA0fZ9mH4388WE+wVt+icT4GoHbQhgGR5IGqiE2a+5N+W7c/tOuZPHhVxfhaIuVKFOcOhgK/9O8HlzxX2VlqDBEktgSH4Je2drCcFo99q4QkdlPO/6pYVwHfc7FE6PArBnnOFnqx X-Forefront-PRVS: 05986C03E0 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAzTUIxMTk7OTo1RHg2Z2NTZUZ3c3hyTm9qektIUGp3MW5KdHpX?= =?utf-8?B?K3FaeWhKU2hNa0ZRNHYxaitXdThaOGFjZmFyZzgzbSt0ZkVxMTNObUExZkFC?= =?utf-8?B?dFVDR1QwZzRHVDN2TXdXZ0hjRmJCdGtvbXZWVEk4Ym84KzVadTJwSEZhNE9z?= =?utf-8?B?b0FtUEZGbStRUVV5NTRSSjRoa1dxSmgvQlcwRVdvcDk0a1l4Vm45U1FxQ0tW?= =?utf-8?B?emc2M1NyTFk5TTlTSzBQSm1oZ0YzUmczL0NFUENEK0lvdko3M2wwU2RDSDdC?= =?utf-8?B?RmZYUEZaRVBpSEtiSi8yd01YT2NjWUhHc1FMNWFrQnhLY2l4Y0VDTHVxeXhF?= =?utf-8?B?OEZMUnZMUXZXRForWHhzUDNGN05QenIzVnFHTjhyZmJSeHBqaG5OajY2RTd0?= =?utf-8?B?WlhhZDB5R0RoVW95c1pFck5FUmNhVXNzUTJPZmJpQmx2VENqcGQyRnFhaStC?= =?utf-8?B?YjVjQkptU1ZPMUZLeC95UW56OWluaFh1WjV3dmcwam9iNDRaOFBhQ3JtTnVa?= =?utf-8?B?TzFBbFNXYktMYXVNOE1leENhcWJIeXhXeHdTL25sZWtzNXBoSWZFOHBxYWRv?= =?utf-8?B?UVRjM3B2eWVUSlBITmd3SExna1dGMUpHTmFtVWJGcU5uL0tFTWxrNWdkek1M?= =?utf-8?B?czVVZGVWZWtkT0NVU1hWajJqbUY3djFGb2JzazBGcEdsdXZjVnRyMzBSSkNx?= =?utf-8?B?SlZwdCtEUWs1RUFENlFXTVRCNnFIYUhRbXdiZ295NVpOa1RrZE1nZ3FaeWtj?= =?utf-8?B?VHRxRG5aMzg2KzB4dk94eGdaREV0Tk5vRndHTjZCbW5RLzVYR3N0amJHTGxq?= =?utf-8?B?TjJDckNDUVV2VG5kbnk1VXFlWmxqcTVvTDRrMnRteG1LQjdoZTN2bXBXSHl1?= =?utf-8?B?ZjRkRHZJWnBMYnF1OHBxb0lRQ1d0TjRTUDlzV0Y3ZWJOUlNYRW9oTmxaRDJq?= =?utf-8?B?a2lWcUtFRnp5bEhINlNPc1hmeDFTU3ZVQ2JaYzJ3SzQvWTN4MElLSXJMVHpi?= =?utf-8?B?bGQwV0lRQWdpS202bngwN2lwNDBYR1RmdDRNaTdVeWp3ZkZLSklwMHZUUTdN?= =?utf-8?B?TW80OUkvbmY2TnByQU9rMTFaZ1VRZFFkL3JOV0wySHFGdEVIRGsxcFFOb3NE?= =?utf-8?B?elR6bGtVbnlZRDQ0VERqRmRXak5rTTBuQlN4c1NDNnVSWHlFS0FaU0pNcVFZ?= =?utf-8?B?V292clkxNE54RUVNUFJLNWllNGRTdm4vUGJGdjBOS0xQcFduTWdSVWhpRHZQ?= =?utf-8?B?b3c1amwvU0xGdWVKbERBZEFZajcrWDRWYjhKYnZNU2ZpMzVQUThmUU91cUlC?= =?utf-8?B?S2dRVy9UQ29WSVBXUFV4VlRqcUZON3JWYnd2cmhFZG1lSGdONEU5VTNvRFV0?= =?utf-8?B?R3hCL3VMcjltNTF6Zkl0aVBFRkxvd2w1SnI3d3RIcmNHNWFCNTBEaVh4L0FQ?= =?utf-8?B?OXdqRnMxSWY3c2NPYjZwZ2N6UGRmWEhxZ0ZGTEdGUXUyZzVPSElIRElXOHNP?= =?utf-8?B?YUlCbTU0V21NY2RUS2xaME15WCtqZFRvM0xmK2cxU1lxMm1YZHloR2JJVVFm?= =?utf-8?B?NnJGMlRxRHBzL0xXWW8yZkZCUkhjRCttVHdBUzhXQU5yZTZZT1JCdXZXQy9U?= =?utf-8?B?OGhUcGhlemlqYndqaGJaR2xXM0Jvb2d4RU5EMjhlRktOOXV2QzZLa2hadWVP?= =?utf-8?Q?rEv9UR8vqpqIAM+pwRjRvbSqcF54s/3/LMEHg?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB119;3:rmJKk/csp/usM7PAxvhhIPT45hDxCzNlVkFRv6D9W3lIMI/Iln9dJcxLNQ54d2UXqweDQRlM+KbZEtThSwjH+fuDCtkAefIL7R/iq2vrGPqMD1aQrqPhxVUQ2nSoAwTzRNej9iHbOhsrluSoOk7f1A==;10:m0S4kd//BBA+RTw5FxXdgnE90SEae+BRUZWPQ1lV8bJ3z/PYBl9SKMPb8a9GbCo+WXPVCUqrMudVxKGpIMFVuuDLDe/ZQcvivpUGkf1S7fQ=;6:cidqdpUM8NXNlMibYzlXnEfywYQPGv0XB1xrMhQ65sFQrS4yv4OtAoeeaNhFGpH+Z9HWlC2HbTwqcSHRmBjcy4t3GK4zb/wXuq2cMJGn+D0WBlCZ9yfzC++1KItHa4tIz3/dkf3LvCSvjbFdy2QCow== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2015 13:57:26.2982 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB119 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 6/5/15 4:17 AM, Borislav Petkov wrote: > On Thu, Jun 04, 2015 at 05:27:28PM -0500, Dinh Nguyen wrote: >> This is my mistake. I applied Alan Tull's patch for suspend-to-ram which >> also touches drivers/edac/altera_edac.c. >> >> https://git.kernel.org/cgit/linux/kernel/git/dinguyen/linux.git/commit/?h=socfpga_for_next_arria10&id=d44a92eb044f4cc1abf34a790d647e9fa356d7b0 >> >> I think I will have to ask Alan to split up his patch and send the part >> that touches altera_edac.c to linux-edac. > > Nah, that's fine. If it is that hunk adding altr_sdram_prepare(), he can > simply add my ACK for the EDAC bits: > > Acked-by: Borislav Petkov > Thanks alot for doing that! But I have sent you a separate patch for this. It would have caused a merge conflict for v4.2 if I left the suspend-to-ram patch as is. Thanks, Dinh