* [PATCH -next] MIPS: traps: Add missing include file
@ 2015-06-05 14:29 Guenter Roeck
2015-06-05 14:35 ` Sergei Shtylyov
2015-06-05 15:03 ` Ralf Baechle
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2015-06-05 14:29 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, linux-kernel, Guenter Roeck, Sergei Shtylyov
Commit 05155ddc2617 ("MIPS: get rid of 'kgdb_early_setup' cruft")
removed the include of linux/kgdb.h from arch/mips/kernel/traps.c.
This results in
arch/mips/kernel/traps.c: In function 'show_stack':
arch/mips/kernel/traps.c:204:14: error: 'kgdb_active' undeclared
arch/mips/kernel/traps.c: In function 'do_trap_or_bp':
arch/mips/kernel/traps.c:877:2: error:
implicit declaration of function 'kgdb_ll_trap'
when building mips:allmodconfig.
Fixes: 05155ddc2617 ("MIPS: get rid of 'kgdb_early_setup' cruft")
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/mips/kernel/traps.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index b5337a3447e7..2a7b38ed23f0 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -29,6 +29,7 @@
#include <linux/bootmem.h>
#include <linux/interrupt.h>
#include <linux/ptrace.h>
+#include <linux/kgdb.h>
#include <linux/kdebug.h>
#include <linux/kprobes.h>
#include <linux/notifier.h>
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] MIPS: traps: Add missing include file
2015-06-05 14:29 [PATCH -next] MIPS: traps: Add missing include file Guenter Roeck
@ 2015-06-05 14:35 ` Sergei Shtylyov
2015-06-05 15:03 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2015-06-05 14:35 UTC (permalink / raw)
To: Guenter Roeck, Ralf Baechle; +Cc: linux-mips, linux-kernel
Hello.
On 6/5/2015 5:29 PM, Guenter Roeck wrote:
> Commit 05155ddc2617 ("MIPS: get rid of 'kgdb_early_setup' cruft")
> removed the include of linux/kgdb.h from arch/mips/kernel/traps.c.
Sorry about that. And thanks for beating me to it. :-)
> This results in
> arch/mips/kernel/traps.c: In function 'show_stack':
> arch/mips/kernel/traps.c:204:14: error: 'kgdb_active' undeclared
The build robot has informed me about that one...
> arch/mips/kernel/traps.c: In function 'do_trap_or_bp':
> arch/mips/kernel/traps.c:877:2: error:
> implicit declaration of function 'kgdb_ll_trap'
... but not about this one.
> when building mips:allmodconfig.
>
> Fixes: 05155ddc2617 ("MIPS: get rid of 'kgdb_early_setup' cruft")
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] MIPS: traps: Add missing include file
2015-06-05 14:29 [PATCH -next] MIPS: traps: Add missing include file Guenter Roeck
2015-06-05 14:35 ` Sergei Shtylyov
@ 2015-06-05 15:03 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2015-06-05 15:03 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-mips, linux-kernel, Sergei Shtylyov
On Fri, Jun 05, 2015 at 07:29:45AM -0700, Guenter Roeck wrote:
Thanks, I folded your fix into the original patch.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-05 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-05 14:29 [PATCH -next] MIPS: traps: Add missing include file Guenter Roeck
2015-06-05 14:35 ` Sergei Shtylyov
2015-06-05 15:03 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox