public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@ezchip.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tile: add init.h to usb.c to avoid compile failure
Date: Fri, 5 Jun 2015 10:42:38 -0400	[thread overview]
Message-ID: <5571B55E.3040704@ezchip.com> (raw)
In-Reply-To: <1433514964-5945-1-git-send-email-paul.gortmaker@windriver.com>

On 06/05/2015 10:36 AM, Paul Gortmaker wrote:
> Pending header cleanups will reveal this file is using the
> init.h content implicitly with the following fail:
>
> arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default]
> arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall'
> arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default]
> arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used
>
> Explicitly add init.h to get arch_initcall and avoid this.
>
> Reported-by: kbuild test robot<fengguang.wu@intel.com>
> Cc: Chris Metcalf<cmetcalf@ezchip.com>
> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
> ---
>
> [adding this to the header move series of commits; see
>   https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com
>   for original series posting. ]
>
>   arch/tile/kernel/usb.c | 1 +
>   1 file changed, 1 insertion(+)

Acked-by: Chris Metcalf <cmetcalf@ezchip.com>

or I'm happy to take it into the tile tree if you'd rather I did.

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com


  reply	other threads:[~2015-06-05 14:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 14:36 [PATCH] tile: add init.h to usb.c to avoid compile failure Paul Gortmaker
2015-06-05 14:42 ` Chris Metcalf [this message]
2015-06-05 14:46   ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5571B55E.3040704@ezchip.com \
    --to=cmetcalf@ezchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox