From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422898AbbFEOm7 (ORCPT ); Fri, 5 Jun 2015 10:42:59 -0400 Received: from mail-db3on0086.outbound.protection.outlook.com ([157.55.234.86]:9294 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1422845AbbFEOmy (ORCPT ); Fri, 5 Jun 2015 10:42:54 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none; Message-ID: <5571B55E.3040704@ezchip.com> Date: Fri, 5 Jun 2015 10:42:38 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paul Gortmaker , Subject: Re: [PATCH] tile: add init.h to usb.c to avoid compile failure References: <1433514964-5945-1-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: <1433514964-5945-1-git-send-email-paul.gortmaker@windriver.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: CY1PR15CA0031.namprd15.prod.outlook.com (25.163.14.41) To AM2PR02MB0771.eurprd02.prod.outlook.com (25.163.146.156) X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR02MB0771; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:AM2PR02MB0771;BCL:0;PCL:0;RULEID:;SRVR:AM2PR02MB0771; X-Forefront-PRVS: 05986C03E0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(377454003)(51704005)(24454002)(479174004)(76176999)(62966003)(19580405001)(5001960100002)(77156002)(77096005)(59896002)(50986999)(54356999)(189998001)(36756003)(46102003)(42186005)(5001770100001)(107886002)(4001350100001)(2950100001)(83506001)(5001920100001)(122386002)(40100003)(19580395003)(66066001)(50466002)(87976001)(87266999)(47776003)(65816999)(15975445007)(92566002)(65956001)(23746002)(33656002)(86362001)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR02MB0771;H:[10.7.0.41];FPR:;SPF:None;MLV:sfv;LANG:en; X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2015 14:42:49.9597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR02MB0771 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/2015 10:36 AM, Paul Gortmaker wrote: > Pending header cleanups will reveal this file is using the > init.h content implicitly with the following fail: > > arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default] > arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall' > arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default] > arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used > > Explicitly add init.h to get arch_initcall and avoid this. > > Reported-by: kbuild test robot > Cc: Chris Metcalf > Signed-off-by: Paul Gortmaker > --- > > [adding this to the header move series of commits; see > https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com > for original series posting. ] > > arch/tile/kernel/usb.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Chris Metcalf or I'm happy to take it into the tile tree if you'd rather I did. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com