From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbbFIB4R (ORCPT ); Mon, 8 Jun 2015 21:56:17 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:50867 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752154AbbFIB4J (ORCPT ); Mon, 8 Jun 2015 21:56:09 -0400 Message-ID: <557647B7.2030302@wwwdotorg.org> Date: Mon, 08 Jun 2015 19:56:07 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Eric Anholt CC: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , linux-clk@vger.kernel.org, Stephen Boyd , Mike Turquette Subject: Re: [PATCH v3 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver. References: <1433807940-15328-1-git-send-email-eric@anholt.net> <1433807940-15328-2-git-send-email-eric@anholt.net> In-Reply-To: <1433807940-15328-2-git-send-email-eric@anholt.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2015 05:58 PM, Eric Anholt wrote: > Unfortunately, the clock manager's registers are not accessible by the > ARM, so we have to request that the firmware modify our clocks for us. > > This driver only registers the clocks at the point they are requested > by a client driver. This is partially to support returning > -EPROBE_DEFER when the firmware driver isn't supported yet, but it > also avoids issues with disabling "unused" clocks due to them not yet > being connected to their consumers in the DT. > diff --git a/drivers/clk/clk-raspberrypi.c b/drivers/clk/clk-raspberrypi.c > +static int rpi_clk_set_state(struct clk_hw *hw, bool on) > + if (ret || (packet[1] & (1 << 1))) { A #define for the shift amount would be nice, so that this statement was a bit more semantic. Aside from that, the series, Acked-by: Stephen Warren