* [PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI @ 2015-05-27 7:45 Ethan Zhao 2015-06-05 9:17 ` Matt Fleming 0 siblings, 1 reply; 4+ messages in thread From: Ethan Zhao @ 2015-05-27 7:45 UTC (permalink / raw) To: tglx, mingo, hpa, fabf; +Cc: x86, linux-kernel, ethan.kernel, Ethan Zhao As descriped in https://bugzilla.kernel.org/show_bug.cgi?id=98721 When kernel 4.0.4 was tested on Oracle and HP system with UEFI mode, no output and login on console. Simplefb was broken on these systems when orig_video_isVGA is VIDEO_TYPE_EFI, so skip it. This patch was tested on Oracle Sun server X5-2 series and HP ProLiant DL380 Gen9 with kernel 4.0.4 Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com> Tested-by: Kunlun Lao <kunlun.lao@oracle.com> --- arch/x86/kernel/sysfb_simplefb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c index 764a29f..f833502 100644 --- a/arch/x86/kernel/sysfb_simplefb.c +++ b/arch/x86/kernel/sysfb_simplefb.c @@ -36,7 +36,7 @@ __init bool parse_mode(const struct screen_info *si, unsigned int i; type = si->orig_video_isVGA; - if (type != VIDEO_TYPE_VLFB && type != VIDEO_TYPE_EFI) + if (type != VIDEO_TYPE_VLFB) return false; for (i = 0; i < ARRAY_SIZE(formats); ++i) { -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI 2015-05-27 7:45 [PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI Ethan Zhao @ 2015-06-05 9:17 ` Matt Fleming 2015-06-05 9:31 ` David Herrmann 0 siblings, 1 reply; 4+ messages in thread From: Matt Fleming @ 2015-06-05 9:17 UTC (permalink / raw) To: Ethan Zhao Cc: tglx, mingo, hpa, fabf, x86, linux-kernel, ethan.kernel, David Herrmann, linux-efi (Cc'ing David) On Wed, 27 May, at 04:45:48PM, Ethan Zhao wrote: > As descriped in https://bugzilla.kernel.org/show_bug.cgi?id=98721 > When kernel 4.0.4 was tested on Oracle and HP system with UEFI mode, no output and > login on console. > > Simplefb was broken on these systems when orig_video_isVGA is VIDEO_TYPE_EFI, so > skip it. > > This patch was tested on Oracle Sun server X5-2 series and HP ProLiant DL380 Gen9 > with kernel 4.0.4 > > Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com> > Tested-by: Kunlun Lao <kunlun.lao@oracle.com> > --- > arch/x86/kernel/sysfb_simplefb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c > index 764a29f..f833502 100644 > --- a/arch/x86/kernel/sysfb_simplefb.c > +++ b/arch/x86/kernel/sysfb_simplefb.c > @@ -36,7 +36,7 @@ __init bool parse_mode(const struct screen_info *si, > unsigned int i; > > type = si->orig_video_isVGA; > - if (type != VIDEO_TYPE_VLFB && type != VIDEO_TYPE_EFI) > + if (type != VIDEO_TYPE_VLFB) > return false; > > for (i = 0; i < ARRAY_SIZE(formats); ++i) { This patch makes sense to me, but I'd really like David to fill us in on the rationale for including VIDEO_TYPE_EFI in the simplefb list in first place, and whether he's aware of any platforms that require simplefb for UEFI. David? -- Matt Fleming, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI 2015-06-05 9:17 ` Matt Fleming @ 2015-06-05 9:31 ` David Herrmann 2015-06-09 8:04 ` ethan zhao 0 siblings, 1 reply; 4+ messages in thread From: David Herrmann @ 2015-06-05 9:31 UTC (permalink / raw) To: Matt Fleming Cc: Ethan Zhao, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Fabian Frederick, the arch/x86 maintainers, linux-kernel, ethan.kernel, linux-efi Hi On Fri, Jun 5, 2015 at 11:17 AM, Matt Fleming <matt@codeblueprint.co.uk> wrote: > (Cc'ing David) > > On Wed, 27 May, at 04:45:48PM, Ethan Zhao wrote: >> As descriped in https://bugzilla.kernel.org/show_bug.cgi?id=98721 >> When kernel 4.0.4 was tested on Oracle and HP system with UEFI mode, no output and >> login on console. >> >> Simplefb was broken on these systems when orig_video_isVGA is VIDEO_TYPE_EFI, so >> skip it. >> >> This patch was tested on Oracle Sun server X5-2 series and HP ProLiant DL380 Gen9 >> with kernel 4.0.4 >> >> Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com> >> Tested-by: Kunlun Lao <kunlun.lao@oracle.com> >> --- >> arch/x86/kernel/sysfb_simplefb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c >> index 764a29f..f833502 100644 >> --- a/arch/x86/kernel/sysfb_simplefb.c >> +++ b/arch/x86/kernel/sysfb_simplefb.c >> @@ -36,7 +36,7 @@ __init bool parse_mode(const struct screen_info *si, >> unsigned int i; >> >> type = si->orig_video_isVGA; >> - if (type != VIDEO_TYPE_VLFB && type != VIDEO_TYPE_EFI) >> + if (type != VIDEO_TYPE_VLFB) >> return false; >> >> for (i = 0; i < ARRAY_SIZE(formats); ++i) { > > This patch makes sense to me, but I'd really like David to fill us in on > the rationale for including VIDEO_TYPE_EFI in the simplefb list in first > place, and whether he's aware of any platforms that require simplefb for > UEFI. simplefb works perfectly fine on EFI systems. There is no need to use vesafb nor efifb anymore. If simplefb does not work on a platform, we should fix it. Hence, I object to this patch. Can you elaborate what exactly the problem is? Are you sure you have CONFIG_FB_SIMPLE=y? If you really want to use efifb instead, please set CONFIG_X86_SYSFB=n. This config option controls whether you want firmware framebuffers to be converted to the generic simple-framebuffer interface, or whether you want to use the old vesa/efi-framebuffer interfaces. Thanks David ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI 2015-06-05 9:31 ` David Herrmann @ 2015-06-09 8:04 ` ethan zhao 0 siblings, 0 replies; 4+ messages in thread From: ethan zhao @ 2015-06-09 8:04 UTC (permalink / raw) To: David Herrmann Cc: Matt Fleming, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Fabian Frederick, the arch/x86 maintainers, linux-kernel, ethan.kernel, linux-efi On 2015/6/5 17:31, David Herrmann wrote: > Hi > > On Fri, Jun 5, 2015 at 11:17 AM, Matt Fleming <matt@codeblueprint.co.uk> wrote: >> (Cc'ing David) >> >> On Wed, 27 May, at 04:45:48PM, Ethan Zhao wrote: >>> As descriped in https://bugzilla.kernel.org/show_bug.cgi?id=98721 >>> When kernel 4.0.4 was tested on Oracle and HP system with UEFI mode, no output and >>> login on console. >>> >>> Simplefb was broken on these systems when orig_video_isVGA is VIDEO_TYPE_EFI, so >>> skip it. >>> >>> This patch was tested on Oracle Sun server X5-2 series and HP ProLiant DL380 Gen9 >>> with kernel 4.0.4 >>> >>> Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com> >>> Tested-by: Kunlun Lao <kunlun.lao@oracle.com> >>> --- >>> arch/x86/kernel/sysfb_simplefb.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c >>> index 764a29f..f833502 100644 >>> --- a/arch/x86/kernel/sysfb_simplefb.c >>> +++ b/arch/x86/kernel/sysfb_simplefb.c >>> @@ -36,7 +36,7 @@ __init bool parse_mode(const struct screen_info *si, >>> unsigned int i; >>> >>> type = si->orig_video_isVGA; >>> - if (type != VIDEO_TYPE_VLFB && type != VIDEO_TYPE_EFI) >>> + if (type != VIDEO_TYPE_VLFB) >>> return false; >>> >>> for (i = 0; i < ARRAY_SIZE(formats); ++i) { >> This patch makes sense to me, but I'd really like David to fill us in on >> the rationale for including VIDEO_TYPE_EFI in the simplefb list in first >> place, and whether he's aware of any platforms that require simplefb for >> UEFI. > simplefb works perfectly fine on EFI systems. There is no need to use > vesafb nor efifb anymore. If simplefb does not work on a platform, we > should fix it. Hence, I object to this patch. Can you elaborate what > exactly the problem is? Are you sure you have CONFIG_FB_SIMPLE=y? Yes, no CONFIG_FB_SIMPLE set. > > If you really want to use efifb instead, please set > CONFIG_X86_SYSFB=n. CONFIG_X86_SYSFB=n. Works. > This config option controls whether you want > firmware framebuffers to be converted to the generic > simple-framebuffer interface, or whether you want to use the old > vesa/efi-framebuffer interfaces. > > Thanks > David Thanks, Ethan ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-09 8:05 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-05-27 7:45 [PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI Ethan Zhao 2015-06-05 9:17 ` Matt Fleming 2015-06-05 9:31 ` David Herrmann 2015-06-09 8:04 ` ethan zhao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox