From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754028AbbFISaI (ORCPT ); Tue, 9 Jun 2015 14:30:08 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:33278 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbbFISaA (ORCPT ); Tue, 9 Jun 2015 14:30:00 -0400 Message-ID: <55772ED0.2060405@linaro.org> Date: Tue, 09 Jun 2015 19:22:08 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mark Brown CC: alsa-devel@alsa-project.org, Rob Herring , Patrick Lai , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kwestfie@codeaurora.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v5 2/2] ASoC: qcom: add apq8016 sound card support References: <1433854702-23654-1-git-send-email-srinivas.kandagatla@linaro.org> <1433854776-23852-1-git-send-email-srinivas.kandagatla@linaro.org> <20150609170738.GI14071@sirena.org.uk> <557727BF.8040807@linaro.org> <20150609180435.GV14071@sirena.org.uk> In-Reply-To: <20150609180435.GV14071@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/15 19:04, Mark Brown wrote: > On Tue, Jun 09, 2015 at 06:51:59PM +0100, Srinivas Kandagatla wrote: >> On 09/06/15 18:07, Mark Brown wrote: > >>> Why not just do these one time at probe, we don't undo them when we shut >>> the DAI down? > >> If I do that Am afraid that the driver would loose the flexibility of >> selecting different MI2S from DT level. Hardcoding which MI2S can got to >> external or internal codec is something that I wanted to avoid from the >> start. > > I don't understand why we'd loose anything - we get init() callbacks on > the DAIs when they're instantiated? > Yes, got it. At dai_link init() level we can do it without losing any flexibility. My bad, I thought you initially suggested me to add this to platform probe() level. >> I will add the shutdown code to reset the configuration. > > OK. >