From: Christian Schoenebeck <linux_oss@crudebyte.com>
To: Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Eric Van Hensbergen <ericvh@kernel.org>
Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel@pengutronix.de,
Robert Schwebel <r.schwebel@pengutronix.de>,
Eric Van Hensbergen <ericvh@kernel.org>
Subject: Re: [PATCH v2 1/4] fs/9p: remove unnecessary and overrestrictive check
Date: Wed, 19 Jul 2023 15:18:33 +0200 [thread overview]
Message-ID: <5578264.lUQuLdSRdS@silver> (raw)
In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v2-1-147d6b93f699@kernel.org>
On Tuesday, July 18, 2023 10:50:15 PM CEST Eric Van Hensbergen wrote:
> This eliminates a check for shared that was overrestrictive and
> duplicated a check in generic_file_readonly_mmap.
>
> Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>
> Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
> Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
> ---
> fs/9p/vfs_file.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 2996fb00387fa..bda3abd6646b8 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -506,8 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma)
>
> if (!(v9ses->cache & CACHE_WRITEBACK)) {
> p9_debug(P9_DEBUG_CACHE, "(no mmap mode)");
"(r/o mmap mode)" ?
> - if (vma->vm_flags & VM_MAYSHARE)
> - return -ENODEV;
> invalidate_inode_pages2(filp->f_mapping);
> return generic_file_readonly_mmap(filp, vma);
> }
>
>
next prev parent reply other threads:[~2023-07-19 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 20:50 [PATCH v2 0/4] fs/9p: fix mmap regression Eric Van Hensbergen
2023-07-18 20:50 ` [PATCH v2 1/4] fs/9p: remove unnecessary and overrestrictive check Eric Van Hensbergen
2023-07-19 13:18 ` Christian Schoenebeck [this message]
2023-07-18 20:50 ` [PATCH v2 2/4] fs/9p: fix typo in comparison logic for cache mode Eric Van Hensbergen
2023-07-18 20:50 ` [PATCH v2 3/4] fs/9p: fix type mismatch in file cache mode helper Eric Van Hensbergen
2023-07-18 20:50 ` [PATCH v2 4/4] fs/9p: remove unnecessary invalidate_inode_pages2 Eric Van Hensbergen
2023-07-19 13:08 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578264.lUQuLdSRdS@silver \
--to=linux_oss@crudebyte.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=r.schwebel@pengutronix.de \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox