Re: [PATCH 3/3] EDAC, mce_amd_inj: Set MISCV on injection

[Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>]

On 6/10/2015 10:33 AM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> When during injection we populate MCi_MISC by writing into misc, we need
> to set the MiscV bit in the corresponding MCi_STATUS register which
> denotes that there's valid info in the MCi_MISC register.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
>   drivers/edac/mce_amd_inj.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
> index 5001d166f54f..021f256b7f11 100644
> --- a/drivers/edac/mce_amd_inj.c
> +++ b/drivers/edac/mce_amd_inj.c
> @@ -248,6 +248,9 @@ static void do_inject(void)
>   	unsigned int cpu = i_mce.extcpu;
>   	u8 b = i_mce.bank;
>   
> +	if (i_mce.misc)
> +		i_mce.status |= MCI_STATUS_MISCV;
> +
>   	if (inj_type == SW_INJ) {
>   		amd_decode_mce(NULL, 0, &i_mce);
>   		return;


Thanks for the catch here and on Patch 2:)

Looks good to me. So you can slap a <Reviewed-by>  on them if needed..

Thanks,
-Aravind.