From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965119AbbFJSRX (ORCPT ); Wed, 10 Jun 2015 14:17:23 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:33484 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964968AbbFJSQx (ORCPT ); Wed, 10 Jun 2015 14:16:53 -0400 Message-ID: <55787F11.8000709@cogentembedded.com> Date: Wed, 10 Jun 2015 21:16:49 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Kishon Vijay Abraham I , balbi@ti.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org CC: nsekhar@ti.com, gregkh@linuxfoundation.org Subject: Re: [PATCH 2/5] usb: dwc3: ep0: preparation for handling non maxpacket aligned transfers > 512 References: <1433927932-32395-1-git-send-email-kishon@ti.com> <1433927932-32395-3-git-send-email-kishon@ti.com> In-Reply-To: <1433927932-32395-3-git-send-email-kishon@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2015 12:18 PM, Kishon Vijay Abraham I wrote: > No functional change. This is in preparation for handling non maxpacket > aligned transfers greater than bounce buffer size. This is basically to > avoid code duplication when using chained TRB transfers to handle > non maxpacket aligned transfers greater than bounce buffer size. > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/usb/dwc3/ep0.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) > diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c > index 713e46a..4998074 100644 > --- a/drivers/usb/dwc3/ep0.c > +++ b/drivers/usb/dwc3/ep0.c [...] > @@ -808,20 +812,24 @@ static void dwc3_ep0_complete_data(struct dwc3 *dwc, > } > > ur = &r->request; > + buf = ur->buf; > + remaining_ur_length = ur->length; > > length = trb->size & DWC3_TRB_SIZE_MASK; > > + maxp = ep0->endpoint.maxpacket; > + > if (dwc->ep0_bounced) { > - unsigned maxp = ep0->endpoint.maxpacket; > - unsigned transfer_size = roundup(ur->length, maxp); > + transfer_size = roundup((ur->length - transfer_size), > + maxp); The innermost parens shouldn't be needed (if thay are, fix the macro instead). [...] > @@ -941,7 +949,8 @@ static void __dwc3_ep0_do_control_data(struct dwc3 *dwc, > } > > maxpacket = dep->endpoint.maxpacket; > - transfer_size = roundup(req->request.length, maxpacket); > + transfer_size = roundup((req->request.length - transfer_size), > + maxpacket); Likewise. [...] WBR, Sergei