From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Sekhar Nori <nsekhar@ti.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] gpio: pcf857x: handle only enabled irqs
Date: Thu, 11 Jun 2015 00:03:03 +0300 [thread overview]
Message-ID: <5578A607.9030602@ti.com> (raw)
In-Reply-To: <CACRpkdaRb6FruKiYQg0g4ZO8cRnT5FSj==gkDb9GTvnnc=FTvg@mail.gmail.com>
On 06/10/2015 10:39 AM, Linus Walleij wrote:
> On Wed, Jun 3, 2015 at 9:33 PM, Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
>
>> Now pcf857x_irq() IRQ's dispatcher will try to run nested
>> IRQ handlers for each GPIO pin which state has changed.
>> Such IRQs are, actually, spurious and nested IRQ handlers
>> have to be called only for IRQs wich were enabled by users.
>> This is not critical issue - just /proc/interrupts
>> will display counters for unused IRQS:
>> 399: 4 0 pcf857x 0 Edge
>> 428: 1 0 pcf857x 13 Edge
>> 430: 1 0 pcf857x 15 Edge
>>
>> Hence, fix it by adding irq_enabled field in struct pcf857x to track
>> enabled GPIO IRQs and corresponding callbacks in pcf857x_irq_chip.
>>
>> Similar functionality was presented in pcf857x driver, commit
>> 21fd3cd1874a ('gpio: pcf857x: call the gpio user handler iff...')
>>
>> and then it was removed by commit
>> a39294bdf4b0 ('gpio: pcf857x: Switch to use gpiolib irqchip...')
>>
>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> Fixes: a39294bdf4b0 ('gpio: pcf857x: Switch to use gpiolib irqchip helpers')
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> This patch does not apply on the "devel" branch in my GPIO
> tree, please rebase it. I do not run a "fixes" branch this
> late in the kernel cycle.
Sure. Done.
--
regards,
-grygorii
prev parent reply other threads:[~2015-06-10 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 19:33 [PATCH] gpio: pcf857x: handle only enabled irqs Grygorii Strashko
2015-06-10 7:39 ` Linus Walleij
2015-06-10 21:03 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578A607.9030602@ti.com \
--to=grygorii.strashko@ti.com \
--cc=geert+renesas@glider.be \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox