From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965083AbbFJVDL (ORCPT ); Wed, 10 Jun 2015 17:03:11 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:46716 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754173AbbFJVDK (ORCPT ); Wed, 10 Jun 2015 17:03:10 -0400 Message-ID: <5578A607.9030602@ti.com> Date: Thu, 11 Jun 2015 00:03:03 +0300 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Linus Walleij CC: Alexandre Courbot , Sekhar Nori , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven Subject: Re: [PATCH] gpio: pcf857x: handle only enabled irqs References: <1433359988-3456-1-git-send-email-grygorii.strashko@ti.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2015 10:39 AM, Linus Walleij wrote: > On Wed, Jun 3, 2015 at 9:33 PM, Grygorii Strashko > wrote: > >> Now pcf857x_irq() IRQ's dispatcher will try to run nested >> IRQ handlers for each GPIO pin which state has changed. >> Such IRQs are, actually, spurious and nested IRQ handlers >> have to be called only for IRQs wich were enabled by users. >> This is not critical issue - just /proc/interrupts >> will display counters for unused IRQS: >> 399: 4 0 pcf857x 0 Edge >> 428: 1 0 pcf857x 13 Edge >> 430: 1 0 pcf857x 15 Edge >> >> Hence, fix it by adding irq_enabled field in struct pcf857x to track >> enabled GPIO IRQs and corresponding callbacks in pcf857x_irq_chip. >> >> Similar functionality was presented in pcf857x driver, commit >> 21fd3cd1874a ('gpio: pcf857x: call the gpio user handler iff...') >> >> and then it was removed by commit >> a39294bdf4b0 ('gpio: pcf857x: Switch to use gpiolib irqchip...') >> >> Cc: Geert Uytterhoeven >> >> Fixes: a39294bdf4b0 ('gpio: pcf857x: Switch to use gpiolib irqchip helpers') >> Signed-off-by: Grygorii Strashko > > This patch does not apply on the "devel" branch in my GPIO > tree, please rebase it. I do not run a "fixes" branch this > late in the kernel cycle. Sure. Done. -- regards, -grygorii