From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754959AbbFKPCD (ORCPT ); Thu, 11 Jun 2015 11:02:03 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:33105 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916AbbFKPCA (ORCPT ); Thu, 11 Jun 2015 11:02:00 -0400 Message-ID: <5579A2E7.9030302@kernel.dk> Date: Thu, 11 Jun 2015 09:01:59 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dan Williams , Jiri Slaby CC: Keith Busch , Neil Brown , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH -stable] block: fix ext_dev_lock lockdep report References: <20150611034540.15034.24413.stgit@dwillia2-desk3.amr.corp.intel.com> <55793DF0.1000406@suse.cz> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2015 08:07 AM, Dan Williams wrote: > On Thu, Jun 11, 2015 at 12:51 AM, Jiri Slaby wrote: >> On 06/11/2015, 05:47 AM, Dan Williams wrote: >>> ================================= >>> [ INFO: inconsistent lock state ] >>> 4.1.0-rc7+ #217 Tainted: G O >>> --------------------------------- >>> inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage. >>> swapper/6/0 [HC0[0]:SC1[1]:HE1:SE0] takes: >>> (ext_devt_lock){+.?...}, at: [] blk_free_devt+0x3c/0x70 >>> {SOFTIRQ-ON-W} state was registered at: >>> [] __lock_acquire+0x461/0x1e70 >>> [] lock_acquire+0xb7/0x290 >>> [] _raw_spin_lock+0x38/0x50 >>> [] blk_alloc_devt+0x6d/0xd0 <-- take the lock in process context >>> [..] >>> [] __lock_acquire+0x3fe/0x1e70 >>> [] ? __lock_acquire+0xe5d/0x1e70 >>> [] lock_acquire+0xb7/0x290 >>> [] ? blk_free_devt+0x3c/0x70 >>> [] _raw_spin_lock+0x38/0x50 >>> [] ? blk_free_devt+0x3c/0x70 >>> [] blk_free_devt+0x3c/0x70 <-- take the lock in softirq >>> [] part_release+0x1c/0x50 >>> [] device_release+0x36/0xb0 >>> [] kobject_cleanup+0x7b/0x1a0 >>> [] kobject_put+0x30/0x70 >>> [] put_device+0x17/0x20 >>> [] delete_partition_rcu_cb+0x16c/0x180 >>> [] ? read_dev_sector+0xa0/0xa0 >>> [] rcu_process_callbacks+0x2ff/0xa90 >>> [] ? rcu_process_callbacks+0x2bf/0xa90 >>> [] __do_softirq+0xde/0x600 >>> >>> Neil sees this in his tests and it also triggers on pmem driver unbind >>> for the libnvdimm tests. This fix is on top of an initial fix by Keith >>> for incorrect usage of mutex_lock() in this path: 2da78092dda1 "block: >>> Fix dev_t minor allocation lifetime". Both this and 2da78092dda1 are >>> candidates for -stable. >> >> And what is *this* in terms of SHA? Thanks. > > Whatever it becomes when applied by Jens, i.e. self-referencing. 4d66e5e9b6d720d8463e11d027bd4ad91c8b1318 -- Jens Axboe