Re: [PATCH 2/6] clocksource: arm_global_timer: Migrate to new 'set-state' interface

Daniel Lezcano
2015-06-11T14:49:59Z

On 06/08/2015 03:40 PM, Viresh Kumar wrote:
> Migrate arm_global_timer driver to the new 'set-state' interface
> provided by the clockevents core, the earlier 'set-mode' interface is
> marked obsolete now.
>
> This also enables us to implement callbacks for new states of clockevent
> devices, for example: ONESHOT_STOPPED.
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@gmail.com>
> Cc: Maxime Coquelin <maxime.coquelin@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/clocksource/arm_global_timer.c | 37 ++++++++++++++++------------------

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> - clk->set_mode = gt_clockevent_set_mode;
> + clk->set_state_shutdown = gt_clockevent_shutdown;
> + clk->set_state_periodic = gt_clockevent_set_periodic;
> + clk->set_state_oneshot = gt_clockevent_shutdown;

nit: it sounds weird to use the same function as the purpose of the
patch is use the new API which is to ventilate those functions (anyway ...)

> clk->set_next_event = gt_clockevent_set_next_event;
> clk->cpumask = cpumask_of(cpu);
> clk->rating = 300;
> @@ -184,7 +181,7 @@ static int gt_clockevents_init(struct clock_event_device *clk)
>
> static void gt_clockevents_stop(struct clock_event_device *clk)
> {
> - gt_clockevent_set_mode(CLOCK_EVT_MODE_UNUSED, clk);
> + gt_clockevent_shutdown(clk);
> disable_percpu_irq(clk->irq);
> }

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |