From: Richard Weinberger <richard@nod.at>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: axboe@kernel.dk, dan.j.williams@intel.com, mingo@kernel.org,
willy@linux.intel.com, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@infradead.org>,
Borislav Petkov <bp@suse.de>,
toshi.kani@hp.com
Subject: Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM
Date: Thu, 11 Jun 2015 23:53:10 +0200 [thread overview]
Message-ID: <557A0346.2000003@nod.at> (raw)
In-Reply-To: <556B7948.2020706@nod.at>
Am 31.05.2015 um 23:12 schrieb Richard Weinberger:
> Am 04.05.2015 um 22:00 schrieb Ross Zwisler:
>> On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote:
>>> Not all architectures have io memory.
>>>
>>> Fixes:
>>> drivers/block/pmem.c: In function ‘pmem_alloc’:
>>> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>> ^
>>> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default]
>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>> ^
>>> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>>> iounmap(pmem->virt_addr);
>>> ^
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> drivers/block/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
>>> index eb1fed5..3ccef9e 100644
>>> --- a/drivers/block/Kconfig
>>> +++ b/drivers/block/Kconfig
>>> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX
>>>
>>> config BLK_DEV_PMEM
>>> tristate "Persistent memory block device support"
>>> + depends on HAS_IOMEM
>>> help
>>> Saying Y here will allow you to use a contiguous range of reserved
>>> memory as one or more persistent block devices.
>>
>> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>
> Ping?
Can someone please pickup this trivial patch?
Thanks,
//richard
next prev parent reply other threads:[~2015-06-11 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 18:58 [PATCH] block: pmem: Add dependency on HAS_IOMEM Richard Weinberger
2015-05-04 20:00 ` Ross Zwisler
2015-05-31 21:12 ` Richard Weinberger
2015-06-11 21:53 ` Richard Weinberger [this message]
2015-06-11 21:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557A0346.2000003@nod.at \
--to=richard@nod.at \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=toshi.kani@hp.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox