From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755266AbbFKVyU (ORCPT ); Thu, 11 Jun 2015 17:54:20 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:36830 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606AbbFKVyS (ORCPT ); Thu, 11 Jun 2015 17:54:18 -0400 Message-ID: <557A0386.2000307@kernel.dk> Date: Thu, 11 Jun 2015 15:54:14 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Richard Weinberger , Ross Zwisler CC: dan.j.williams@intel.com, mingo@kernel.org, willy@linux.intel.com, linux-kernel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Borislav Petkov , toshi.kani@hp.com Subject: Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM References: <1430765937-32694-1-git-send-email-richard@nod.at> <1430769649.19214.1.camel@theros.lm.intel.com> <556B7948.2020706@nod.at> <557A0346.2000003@nod.at> In-Reply-To: <557A0346.2000003@nod.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2015 03:53 PM, Richard Weinberger wrote: > Am 31.05.2015 um 23:12 schrieb Richard Weinberger: >> Am 04.05.2015 um 22:00 schrieb Ross Zwisler: >>> On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote: >>>> Not all architectures have io memory. >>>> >>>> Fixes: >>>> drivers/block/pmem.c: In function ‘pmem_alloc’: >>>> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration] >>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size); >>>> ^ >>>> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default] >>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size); >>>> ^ >>>> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] >>>> iounmap(pmem->virt_addr); >>>> ^ >>>> >>>> Signed-off-by: Richard Weinberger >>>> --- >>>> drivers/block/Kconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig >>>> index eb1fed5..3ccef9e 100644 >>>> --- a/drivers/block/Kconfig >>>> +++ b/drivers/block/Kconfig >>>> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX >>>> >>>> config BLK_DEV_PMEM >>>> tristate "Persistent memory block device support" >>>> + depends on HAS_IOMEM >>>> help >>>> Saying Y here will allow you to use a contiguous range of reserved >>>> memory as one or more persistent block devices. >>> >>> Reviewed-by: Ross Zwisler >> >> Ping? > > Can someone please pickup this trivial patch? I'll fold it in. -- Jens Axboe