* [PATCH] block: pmem: Add dependency on HAS_IOMEM
@ 2015-05-04 18:58 Richard Weinberger
2015-05-04 20:00 ` Ross Zwisler
0 siblings, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2015-05-04 18:58 UTC (permalink / raw)
To: axboe
Cc: dan.j.williams, ross.zwisler, mingo, willy, linux-kernel,
Richard Weinberger
Not all architectures have io memory.
Fixes:
drivers/block/pmem.c: In function ‘pmem_alloc’:
drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
^
drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default]
pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
^
drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(pmem->virt_addr);
^
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/block/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index eb1fed5..3ccef9e 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX
config BLK_DEV_PMEM
tristate "Persistent memory block device support"
+ depends on HAS_IOMEM
help
Saying Y here will allow you to use a contiguous range of reserved
memory as one or more persistent block devices.
--
1.8.4.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM
2015-05-04 18:58 [PATCH] block: pmem: Add dependency on HAS_IOMEM Richard Weinberger
@ 2015-05-04 20:00 ` Ross Zwisler
2015-05-31 21:12 ` Richard Weinberger
0 siblings, 1 reply; 5+ messages in thread
From: Ross Zwisler @ 2015-05-04 20:00 UTC (permalink / raw)
To: Richard Weinberger; +Cc: axboe, dan.j.williams, mingo, willy, linux-kernel
On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote:
> Not all architectures have io memory.
>
> Fixes:
> drivers/block/pmem.c: In function ‘pmem_alloc’:
> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
> ^
> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default]
> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
> ^
> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(pmem->virt_addr);
> ^
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/block/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index eb1fed5..3ccef9e 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX
>
> config BLK_DEV_PMEM
> tristate "Persistent memory block device support"
> + depends on HAS_IOMEM
> help
> Saying Y here will allow you to use a contiguous range of reserved
> memory as one or more persistent block devices.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM
2015-05-04 20:00 ` Ross Zwisler
@ 2015-05-31 21:12 ` Richard Weinberger
2015-06-11 21:53 ` Richard Weinberger
0 siblings, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2015-05-31 21:12 UTC (permalink / raw)
To: Ross Zwisler; +Cc: axboe, dan.j.williams, mingo, willy, linux-kernel
Am 04.05.2015 um 22:00 schrieb Ross Zwisler:
> On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote:
>> Not all architectures have io memory.
>>
>> Fixes:
>> drivers/block/pmem.c: In function ‘pmem_alloc’:
>> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>> ^
>> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default]
>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>> ^
>> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>> iounmap(pmem->virt_addr);
>> ^
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/block/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
>> index eb1fed5..3ccef9e 100644
>> --- a/drivers/block/Kconfig
>> +++ b/drivers/block/Kconfig
>> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX
>>
>> config BLK_DEV_PMEM
>> tristate "Persistent memory block device support"
>> + depends on HAS_IOMEM
>> help
>> Saying Y here will allow you to use a contiguous range of reserved
>> memory as one or more persistent block devices.
>
> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Ping?
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM
2015-05-31 21:12 ` Richard Weinberger
@ 2015-06-11 21:53 ` Richard Weinberger
2015-06-11 21:54 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2015-06-11 21:53 UTC (permalink / raw)
To: Ross Zwisler
Cc: axboe, dan.j.williams, mingo, willy, linux-kernel, Jens Axboe,
Christoph Hellwig, Borislav Petkov, toshi.kani
Am 31.05.2015 um 23:12 schrieb Richard Weinberger:
> Am 04.05.2015 um 22:00 schrieb Ross Zwisler:
>> On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote:
>>> Not all architectures have io memory.
>>>
>>> Fixes:
>>> drivers/block/pmem.c: In function ‘pmem_alloc’:
>>> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>> ^
>>> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default]
>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>> ^
>>> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>>> iounmap(pmem->virt_addr);
>>> ^
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> drivers/block/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
>>> index eb1fed5..3ccef9e 100644
>>> --- a/drivers/block/Kconfig
>>> +++ b/drivers/block/Kconfig
>>> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX
>>>
>>> config BLK_DEV_PMEM
>>> tristate "Persistent memory block device support"
>>> + depends on HAS_IOMEM
>>> help
>>> Saying Y here will allow you to use a contiguous range of reserved
>>> memory as one or more persistent block devices.
>>
>> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>
> Ping?
Can someone please pickup this trivial patch?
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM
2015-06-11 21:53 ` Richard Weinberger
@ 2015-06-11 21:54 ` Jens Axboe
0 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2015-06-11 21:54 UTC (permalink / raw)
To: Richard Weinberger, Ross Zwisler
Cc: dan.j.williams, mingo, willy, linux-kernel, Jens Axboe,
Christoph Hellwig, Borislav Petkov, toshi.kani
On 06/11/2015 03:53 PM, Richard Weinberger wrote:
> Am 31.05.2015 um 23:12 schrieb Richard Weinberger:
>> Am 04.05.2015 um 22:00 schrieb Ross Zwisler:
>>> On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote:
>>>> Not all architectures have io memory.
>>>>
>>>> Fixes:
>>>> drivers/block/pmem.c: In function ‘pmem_alloc’:
>>>> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>>> ^
>>>> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default]
>>>> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
>>>> ^
>>>> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>>>> iounmap(pmem->virt_addr);
>>>> ^
>>>>
>>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>>> ---
>>>> drivers/block/Kconfig | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
>>>> index eb1fed5..3ccef9e 100644
>>>> --- a/drivers/block/Kconfig
>>>> +++ b/drivers/block/Kconfig
>>>> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX
>>>>
>>>> config BLK_DEV_PMEM
>>>> tristate "Persistent memory block device support"
>>>> + depends on HAS_IOMEM
>>>> help
>>>> Saying Y here will allow you to use a contiguous range of reserved
>>>> memory as one or more persistent block devices.
>>>
>>> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>>
>> Ping?
>
> Can someone please pickup this trivial patch?
I'll fold it in.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-11 21:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-04 18:58 [PATCH] block: pmem: Add dependency on HAS_IOMEM Richard Weinberger
2015-05-04 20:00 ` Ross Zwisler
2015-05-31 21:12 ` Richard Weinberger
2015-06-11 21:53 ` Richard Weinberger
2015-06-11 21:54 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox