From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439AbbFLFEM (ORCPT ); Fri, 12 Jun 2015 01:04:12 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:42120 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbbFLFEJ (ORCPT ); Fri, 12 Jun 2015 01:04:09 -0400 X-AuditID: cbfee68f-f793b6d000005f66-c8-557a68475d15 Message-id: <557A6846.8030008@samsung.com> Date: Fri, 12 Jun 2015 14:04:06 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Greg KH Cc: balbi@ti.com, myungjoo.ham@samsung.com, k.kozlowski@samsung.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type References: <1434075006-2931-1-git-send-email-cw00.choi@samsung.com> <20150612042906.GB10691@kroah.com> In-reply-to: <20150612042906.GB10691@kroah.com> Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsWyRsSkQNc9oyrUoLNbzOLg/XqL5sXr2Sxe vzC0uLxrDpvFomWtzBa3G1ewObB57J+7ht2jb8sqRo/jN7YzeXzeJBfAEsVlk5Kak1mWWqRv l8CVMXn1X9aCfq6KcweOMjYwtnF0MXJwSAiYSPy4FN3FyAlkiklcuLeerYuRi0NIYCmjxKXl l5ghEiYS/a23WSESixglLpxcwwzhPGCU+Nb3lA2kildAS+L+ufXsIFNZBFQlFl72AgmzAYX3 v7gBViIqECaxcvoVFohyQYkfk++B2SICGhIvj94Cs5kF6iR6988GqxcWKJS43zKZCcQWEsiU 2LtrHTuIzSmgLzF35Ul2iHotifU7jzNB2PISm9e8BbtNQmAXu8SLBW/AilgEBCS+TT7EAvGx rMSmA1CPSUocXHGDZQKj2CwkJ81CMnYWkrELGJlXMYqmFiQXFCelFxnrFSfmFpfmpesl5+du YgRG1+l/z/p3MN49YH2IUYCDUYmHN0GrKlSINbGsuDL3EKMp0BUTmaVEk/OBMZxXEm9obGZk YWpiamxkbmmmJM67UOpnsJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQZGVVmLpRlx23Ju/z33 1kRBVkHwwY+rb0xr/H2lt6/+bsE6rUbltYJ4a2DFEavupV/k8i6a155mPLNU/rPU1rmbsgot pvz6aRcz/9eylZmWEg8Xlpmlngq1aW1orb7ac6tT7tbhCY+Xbb/y7pB2ivT3bMaPRYe+Gsz+ brb4oeLqLyHTWI5rbHiip8RSnJFoqMVcVJwIAN6bycypAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jAV33jKpQg9ctghYH79dbNC9ez2bx +oWhxeVdc9gsFi1rZba43biCzYHNY//cNewefVtWMXocv7GdyePzJrkAlqgGRpuM1MSU1CKF 1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoN1KCmWJOaVAoYDE4mIl fTtME0JD3HQtYBojdH1DguB6jAzQQMIaxozJq/+yFvRzVZw7cJSxgbGNo4uRk0NCwESiv/U2 K4QtJnHh3nq2LkYuDiGBRYwSF06uYYZwHjBKfOt7ygZSxSugJXH/3Hr2LkYODhYBVYmFl71A wmxA4f0vboCViAqESaycfoUFolxQ4sfke2C2iICGxMujt8BsZoE6id79s8HqhQUKJe63TGYC sYUEMiX27lrHDmJzCuhLzF15kh2iXkti/c7jTBC2vMTmNW+ZJzAKzEKyYhaSsllIyhYwMq9i FE0tSC4oTkrPNdIrTswtLs1L10vOz93ECI7eZ9I7GFc1WBxiFOBgVOLhTdCqChViTSwrrsw9 xCjBwawkwmtiCxTiTUmsrEotyo8vKs1JLT7EaAoMgInMUqLJ+cDEklcSb2hsYmZkaWRuaGFk bK4kznsy3ydUSCA9sSQ1OzW1ILUIpo+Jg1OqgTHsYL1Qo94h5rlNaVN+X7d7tNrJ3v7jhscb yk+l/r7wfdWcQHNX8Smfq2037DZuyl77x4e/dNJ89V2O3ete/rE9vqzzrUKDwwMT8znRhxbr zVZxPfJGsKs+wz545o+rs2ycl0qsNglsj5Rd1JDG9ZFLe4XojL+JP1Vv8fhI7Ezini4kEbaH lVmJpTgj0VCLuag4EQC7OToz9AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Greg, On 06/12/2015 01:29 PM, Greg KH wrote: > On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote: >> This patch just redefine the unique id of supported external connectors without >> 'enum extcon' type. Because unique id would be used on devictree file(*.dts) to >> indicate the specific external connectors like key number of input framework. >> So, I have the plan to move this definitions to following header file which >> includes the unique id of supported external connectors. >> - include/dt-bindings/extcon/extcon.h > > Do we have other such fields in dt-bindings that are not enumerated > types? I think that 'integer' type is more appropriate than enumerated type in header file of includ/dt-bindings/ as following: - Previous defintions enum extcon { /* USB external connector */ EXTCON_USB = 0x1, EXTCON_USB_HOST = 0x2, ...... }; - New definitions without specific 'enum extcon' type. #define EXTCON_USB 1 #define EXTCON_USB_HOST 2 ...... > > What's wrong with keeping this as-is and not changing to an integer? > >> Fixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string") > > How is this a bugfix? It is my mistake. This patch is not bug fix. Best Regards, Chanwoo Choi