From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbbFLJZa (ORCPT ); Fri, 12 Jun 2015 05:25:30 -0400 Received: from mail-bn1on0086.outbound.protection.outlook.com ([157.56.110.86]:49823 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750781AbbFLJZY (ORCPT ); Fri, 12 Jun 2015 05:25:24 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; mvista.com; dkim=none (message not signed) header.d=none; Message-ID: <557AA57D.1010104@xilinx.com> Date: Fri, 12 Jun 2015 11:25:17 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arun Chandran , Michal Simek CC: , Michal Simek , =?windows-1252?Q?S=F6ren_Brinkmann?= , Subject: Re: [PATCH v2] ARM: zynq: Fix earlyprintk in big endian mode References: <1433945584-16379-1-git-send-email-achandran@mvista.com> <1434092004-21385-1-git-send-email-achandran@mvista.com> In-Reply-To: <1434092004-21385-1-git-send-email-achandran@mvista.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21608.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD023;1:PAuYzD0Y4qe0oE/FiSzm/9CtHdt7V896FRYhS11+2jBbMsc2oNtjc8Gw+ITGjOda8NNb5PANC+l4lgpynPmnu7ePgvd1LJc+t3uHO95nfdTPHsst+UANfT0hxpTokDaIoREeDl6aH4pRUC7xdQbl61LX3w2a3Rk8VobHYMcktMePdzMyjUqh4m/xciTwi2t8P1VtUsne1uY0GRoNN6lsLq17EWxJbcdij/fgHa7gO/w6ANGab/3/Pzo7r7ApWL28fjllnDvte5m10tcKPYVWc4OUSBtx6tUC4lhu0c11M9s= X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(24454002)(199003)(189002)(377454003)(164054003)(479174004)(51704005)(83506001)(50466002)(4001350100001)(5001770100001)(19580405001)(36386004)(19580395003)(189998001)(2950100001)(6806004)(80316001)(62966003)(65806001)(65956001)(77156002)(86362001)(77096005)(64126003)(50986999)(87266999)(5001960100002)(54356999)(92566002)(63266004)(87936001)(76176999)(36756003)(47776003)(23746002)(46102003)(106466001)(33656002)(107986001)(4001450100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2FFO11HUB009;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB009;2:O/7cj+cw42i1fuusb8FS7bCSpXeXDBDS6YBQXZVzw9FWVa+poO1Hhc9sG3zE++F5;2:pfCbIpZOOKt+jvHqdwMkkGaYnj3LpKJbagX4HVQBR9Fe5RDk3MG7v9DnJ21zel+7oHfFnQmzk/pRMOmaifCKey8399CXq1aACTzzVqmm/2C6/CnMWCpHwTx2aElimZQOx4+4FsdQ13ErNehQT0JSEnk0DkJ6mIi8LoTeXSj8124Kgo0OK//eiEoWrlo5EwZqfHikFLVk7Or7zbwbbO+S+5EZMGLck+7AVeLlDGEa+SU=;6:g+UgWyj9Hfzs7aB9vpu6JyCbdVCLZJEfhJMTmCklYFvBn2TDx1JiaePc3RieIn6r0LXw/X4SmbFHTRaFFwG6CYu9WBx6smZARtVs91pny26TVtzhI12ECRKEflP7rpE6x4O55b3yHqGWvPE7151Sqe9cWTAKopoTiO+tBDwRbC9lFq8tS6ifOQxgN3ocufOexu/n/SV9xOhCd2DWvMxO8og6OkPEUjTTZcz/Ys8GdleIUrUgb2KaJ6F59l0FXs0yFb33cKBe1xVJNInhbVr84uIBJXoVdgHnA4q2uL8/cyqQtBWmpHAV2RssyL6QBYUz+4Y0dFfer1XrYdiUsnprFFIkesqJAmWvtg0DWSC+IpD1QJH7rmKg3luKrN/SCEtfTA2ui8gM2iFJBxo4b7zju4ZJHBjuNNR4nEo0fCCiiWTzElFY1I1dApXQxkir7I4Y7uAA1uN9dY7RN312VoLftEWla+zxdE1GA3i6ThYeQNQHo9ykUYj1pWol6Cl21Y74 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB009; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:BY2FFO11HUB009;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB009; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB009;3:QSj4nuJZwr1xVkC0JnL8pzdYLVI676aFx7Nns0XyX4kO1liKRTmuDDeksSe0YW2OFGhFqceXPQkPl9ew9ztrvyQ0XYbJxAWPGZE+8x6eIs1HaEJR4joRIpmF983l8MUcUaLzzn845WFRCCPDqrRwh4/qcM6CIVlv8aRySbDCOOJA18gjyn37FPOqBhNUp66uHChwtnoDcNR7RlLe37q5ssA1ucnCbXgDBokNasIrWu8TfV5Q/OmjzpTd5ldbY+Z6lee0mnGbSWUaUP+fX68O9+cVQ0oQEnJUwBXlPwaRwOczKsPWQ3uhXDFb6KKdfxRo X-Forefront-PRVS: 060503E79B X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2FFO11HUB009;9:JpVO/EWvItAwb3BzeeAbQJrYlv5KvodNTonMw?= =?Windows-1252?Q?IG8yntPOQOYjjMZ6BhivFG642Fbn8KRHpstW/KHicwBewWi+QkRqHI+7?= =?Windows-1252?Q?M4RpO8gkeQou3ba2kZMa8+Gdj6/78041lWwD+pDvzqMw4mcVi2UjwAU1?= =?Windows-1252?Q?JYhk4EIWQDK2eMshx1+RPhgs2ZdpHqKHEbGvAKFyakY8TS7Vx7TBtEr4?= =?Windows-1252?Q?yCqAs8yVFCE19fJoHKk7SmAylEnO3RY+JAlTuIuLjx+7Sqh+c0Eqim1A?= =?Windows-1252?Q?eSIDB0BAkTkH/CeorYfZcB8pMiVrREB4IAXiWNRQwPDthsHSft90Z8+I?= =?Windows-1252?Q?4BWeXjC31Tomu13KvHU+PjXjmVe0/PQSsY/AiOZXc5y6TKZ1ICnsqVSs?= =?Windows-1252?Q?Qexy7a75p6PeNLsX09V6G3qT7fnzwsCsOogCF7fkFuTsFBZBeJHdARYc?= =?Windows-1252?Q?r1Kf5OH6+dGWAKe/Vab8J/9przFdy2Mj3AatyvEIc3SU1z9LQN2ltEoe?= =?Windows-1252?Q?MzoBvv3YX9hrCPcfAC3Ysp6OjQzxcgelGDJYMcePO5d9483XvF3VOlU0?= =?Windows-1252?Q?F5XL+iRjithic63ubOK8AzV7Bvs1wgl2f0J9Lu53CsYR9kezyNpq3e/s?= =?Windows-1252?Q?RrkSh9v/Pvf0NCEAZ/IX1S4/Btx6aBUuwE9XZujBxqzb+xxxlCiysLr9?= =?Windows-1252?Q?4j3ofXF8YFzsnQQFS4dpfJMc3XLj3aLyB876LpAAnBTq9zPtf8Brvm3e?= =?Windows-1252?Q?Q1UCN8omAyQuBq5D+pZCOdmbQmAs36lhmZPZr0ktYDUVEGvB+kVklr94?= =?Windows-1252?Q?xQSJSTGAO90QkBFcT+bq55K+zzUAp7Cmfqo1XThGDusnOtsm1Cwg0/Uu?= =?Windows-1252?Q?V/ZLtqaTpOCaEo4M1p+jpTr5A3zH1AAvwQGAJPJVPc9kE2DG76BUZNxq?= =?Windows-1252?Q?Sb8ftfGSqNXO7HICVn0cWmsDEWBdcW0b6SGCj271u4f9lk1ocitJLIUq?= =?Windows-1252?Q?3AkItBj3/Xh2vElC6LfLC82gyEgE3leToAqGANyARVneay8Ym8V89149?= =?Windows-1252?Q?jAh60BjH6dGlgJ5dKRBwXPTyMogHb643k0+TtkuCzTeqZSi5nc9QYZ7r?= =?Windows-1252?Q?xodd7STgSncj/wqIVAjUkzKH+V091Tzg61JKYFG9UhtTM41ZPcGrr3TG?= =?Windows-1252?Q?Biz04SFk9Kypgr+bC9nTqHtAwjeSHY=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB009;3:C8V1dplK96b92h75x6OzcmPY6J5dUP0Lnqfkbe+NXV3q/LV4pp8edvnNf+gBU4G/LN5ezZB8Vx13tNeq2tmHoePsuPocP0ZxV1CVOPJiVtGYj85LicIsN9JfwQ7+socDyKc+iBQYt/RSy45FBTLb/Q==;10:qjFAgeNM/rjjMJyIHMiBMoSnxomSgeAhaOWH3qUCbg3K5PrLGZsvJKIMzVnI/tjMu4b5eIbIFZ0CWdHr2gIPtuSqjcimARVixVO1b47Wt5Q= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2015 09:25:22.1656 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2FFO11HUB009 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2015 08:53 AM, Arun Chandran wrote: > earlyprintk messages are not appearing on the terminal > emulator during a big endian kernel boot. In BE mode > sending full words to UART will result in unprintable > characters as they are byte swapped versions of printable > ones. So send only bytes. > > Signed-off-by: Arun Chandran > --- > --- > Changes since v1: > removed the byte swapping logic. Just send characters instead. > --- > arch/arm/include/debug/zynq.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/include/debug/zynq.S b/arch/arm/include/debug/zynq.S > index bd13ded..de86b92 100644 > --- a/arch/arm/include/debug/zynq.S > +++ b/arch/arm/include/debug/zynq.S > @@ -38,7 +38,7 @@ > .endm > > .macro senduart,rd,rx > - str \rd, [\rx, #UART_FIFO_OFFSET] @ TXDATA > + strb \rd, [\rx, #UART_FIFO_OFFSET] @ TXDATA > .endm > > .macro waituart,rd,rx > ok - this works too. Tested-by: Michal Simek Thanks, Michal