public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Andi Kleen <ak@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
	Stephane Eranian <eranian@google.com>,
	mathieu.poirier@linaro.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches
Date: Fri, 12 Jun 2015 19:13:59 +0300	[thread overview]
Message-ID: <557B0547.4000503@intel.com> (raw)
In-Reply-To: <557AEAF9.5050507@gmail.com>

On 12/06/2015 5:21 p.m., David Ahern wrote:
> On 6/12/15 4:34 AM, Adrian Hunter wrote:
>> On 12/06/15 03:47, David Ahern wrote:
>>> On 6/11/15 8:15 AM, Peter Zijlstra wrote:
>>>>> This new PERF_RECORD_SWITCH event does not have those problems
>>>>> and it also has a couple of other small advantages. It is
>>>>> easier to use because it is an auxiliary event (like mmap,
>>>>> comm and task events) which can be enabled by setting a single
>>>>> bit. It is smaller than sched:sched_switch and easier to parse.
>>>>
>>>> Right, so the one wee problem I have is that this only provides sched_in
>>>> data, I imagine people might be interested in sched_out as well.
>>>
>>> Yes and with the option of collecting callchains for sched_out.
>>
>> So what do you want that is different different from
>> PERF_COUNT_SW_CONTEXT_SWITCHES? And why?
>>
>
> My 'perf sched timehist' command can use either sched_switch and context
> switches. As you have pointed out you need to collect them system wide even if
> you only care about a subset of tasks. If you are going to add a sched_in
> there is good symmetry by also having a sched_out that is used and generated
> in a consistent manner.

Yes I will certainly add sched out, but the new thing is not a sample so it 
does not have callchains. But presumably you could use 
PERF_COUNT_SW_CONTEXT_SWITCHES as well?

  reply	other threads:[~2015-06-12 16:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 14:21 [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context switches Adrian Hunter
2015-06-11 14:15 ` Peter Zijlstra
2015-06-11 16:34   ` Andi Kleen
2015-06-11 16:54     ` Peter Zijlstra
2015-06-12  0:47   ` David Ahern
2015-06-12 10:34     ` Adrian Hunter
2015-06-12 14:21       ` David Ahern
2015-06-12 16:13         ` Adrian Hunter [this message]
2015-06-12 11:12   ` Adrian Hunter
2015-06-12 12:09     ` Peter Zijlstra
2015-06-12 12:36       ` Arnaldo Carvalho de Melo
2015-06-12 13:15         ` Adrian Hunter
2015-06-12 13:28           ` Pawel Moll
2015-06-12 13:52             ` Pawel Moll
2015-06-12 14:30             ` David Ahern
2015-06-12 14:29     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557B0547.4000503@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox