From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754591AbbFLS7T (ORCPT ); Fri, 12 Jun 2015 14:59:19 -0400 Received: from mga03.intel.com ([134.134.136.65]:37303 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbbFLS7R (ORCPT ); Fri, 12 Jun 2015 14:59:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,602,1427785200"; d="scan'208";a="586849978" Message-ID: <557B2C04.4070406@intel.com> Date: Fri, 12 Jun 2015 11:59:16 -0700 From: Tadeusz Struk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephan Mueller CC: herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, keescook@chromium.org, jwboyer@redhat.com, richard@nod.at, steved@redhat.com, qat-linux@intel.com, dhowells@redhat.com, linux-crypto@vger.kernel.org, james.l.morris@oracle.com, jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net, vgoyal@redhat.com Subject: Re: [PATCH RFC v4 1/4] MPILIB: add mpi_read_buf(), mpi_copy() and mpi_get_size() helpers References: <20150611190533.31826.13956.stgit@tstruk-mobl1> <20150611190538.31826.97258.stgit@tstruk-mobl1> <8104647.vddsXnptAF@tauon.atsec.com> In-Reply-To: <8104647.vddsXnptAF@tauon.atsec.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2015 09:21 AM, Stephan Mueller wrote: >> +void *mpi_get_buffer(MPI a, unsigned *nbytes, int *sign) >> >+{ >> >+ uint8_t *buf, *p; >> >+ int n, ret; >> >+ >> >+ if (!nbytes) >> >+ return NULL; >> >+ >> >+ n = mpi_get_size(a); > Shouldn't n be unsigned int? You are right, thanks.