From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbbFNXv3 (ORCPT ); Sun, 14 Jun 2015 19:51:29 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:52676 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbbFNXvT (ORCPT ); Sun, 14 Jun 2015 19:51:19 -0400 X-AuditID: cbfec7f5-f794b6d000001495-0b-557e1373e1bf Message-id: <557E136E.7090409@samsung.com> Date: Mon, 15 Jun 2015 08:51:10 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Anand Moon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv6 2/4] ARM: dts: exynos5422-odroidxu3: Enable TMU at Exynos5422 base References: <1434277445-5243-1-git-send-email-linux.amoon@gmail.com> <1434277445-5243-2-git-send-email-linux.amoon@gmail.com> In-reply-to: <1434277445-5243-2-git-send-email-linux.amoon@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e/4Vd1i4bpQg3tvtCzmHznHatH/ZiGr xblXKxktXr8wtOh//JrZYtPja6wWl3fNYbOYcX4fk8W6jbfYLW5f5rVYev0ik8WE6WtZLFr3 HmF34PVYM28No0dLcw+bx+W+XiaPnbPusnusXP6FzWPTqk42j81L6j36tqxi9Pi8SS6AM4rL JiU1J7MstUjfLoEr48Pvn0wFx0UqZvzuZG5gPC3QxcjJISFgIrF78QtWCFtM4sK99WxdjFwc QgJLGSVO/N/KDOE8ZZR4fXkOI0gVr4CWxI+v11hAbBYBVYn5DzvAbDYBY4nNy5ewgdiiAhES by+fZIKoF5T4MfkeC8ggEYG1TBJT164Gc5gF2hkl7rydDdYhLBAl0fnxItA6DqB19RIH/kmB hDkFXCX2npzBCBJmFtCTuH9RCyTMLCAvsXnNW+YJjAKzkKyYhVA1C0nVAkbmVYyiqaXJBcVJ 6blGesWJucWleel6yfm5mxghMfR1B+PSY1aHGAU4GJV4eCM+1YYKsSaWFVfmHmKU4GBWEuFd w18XKsSbklhZlVqUH19UmpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQZGsQN7 j1acfF+9+ee6G3O4mKSD9Lhn796kaM5Sd+P22SW1N+Tz/0UF9zitPv7yYFfgJ59nc52zvtxV 4fg4k4VXT9r/n2HqlWVfGMpnXmTYvX3WncYPexK2erIw7mH4uX6TU4rBJ66vf4puNc4J2Xe3 eXPy0wes6oe+VuVeuRlyyy1CcIv/lu1GN5RYijMSDbWYi4oTAZctK4OdAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.06.2015 19:24, Anand Moon wrote: > This changes enables TMU IP block on the Exynos5422 Odroid-XU3 > device. > > Signed-off-by: Anand Moon > Tested-by: Markus Reichl > Acked-by: Lukasz Majewski > --- > Changes rebase on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung branch for-next > Changes from v5: Use LDO7 regulator instead of LD010. > > The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU. > > I think the schematics are missing some of details but it can be deducted that: > 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5 > pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]). > 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of > S2MPS11 PMIC. > 3. I confirmed with the Exynos5422 datasheet that these > VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES). > > So the LDO7 it is... but before using it there is a caveat. The LDO7 > is also connected to VDD of MIPI, HDMI and few more. So when you use > this regulator in TMU it may be turned off by TMU driver (e.g. during > unbind). In such case these other blocks also should be tested and > checked whether they take this regulator and enable it. Why did you took my email and pasted it here? http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/343702.html It is written now in first person so it pretends that you wrote this. You are actually doing this for second time - taking my reply and putting into commit message or changelog. Why? And where is proper changelog? Krzysztof > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index a2f9941..b6570fc 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -474,6 +474,31 @@ > status = "okay"; > }; > > +&tmu_cpu0 { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > +&tmu_cpu1 { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > +&tmu_cpu2 { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > +&tmu_cpu3 { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > +&tmu_gpu { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > &rtc { > status = "okay"; > clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; >