From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbbFOALX (ORCPT ); Sun, 14 Jun 2015 20:11:23 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:52740 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbbFOALQ (ORCPT ); Sun, 14 Jun 2015 20:11:16 -0400 X-AuditID: cbfec7f5-f794b6d000001495-05-557e18215400 Message-id: <557E181C.7070209@samsung.com> Date: Mon, 15 Jun 2015 09:11:08 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Anand Moon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv6 2/4] ARM: dts: exynos5422-odroidxu3: Enable TMU at Exynos5422 base References: <1434277445-5243-1-git-send-email-linux.amoon@gmail.com> <1434277445-5243-2-git-send-email-linux.amoon@gmail.com> In-reply-to: <1434277445-5243-2-git-send-email-linux.amoon@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e/4ZV1FibpQgyUXmSzmHznHatH/ZiGr xblXKxktXr8wtOh//JrZYtPja6wWl3fNYbOYcX4fk8W6jbfYLW5f5rVYeh2oacL0tSwWrXuP sDvweqyZt4bRo6W5h83jcl8vk8fOWXfZPVYu/8LmsWlVJ5vH5iX1Hn1bVjF6fN4kF8AZxWWT kpqTWZZapG+XwJWx7+FG5oJ1vBWX1n9lamB8xdXFyMkhIWAisXPjdWYIW0ziwr31bF2MXBxC AksZJR7dOsgE4TxllPh1eCI7SBWvgJbE3vb3rCA2i4CqxK5HB5hAbDYBY4nNy5ewgdiiAhES by+fZIKoF5T4MfkeC8ggEYG1TBJT164Gc5gF2hkl7rydDdYhLBAl0fnxItAdHEDr6iUO/JMC CXMKuErsPTmDESTMLKAncf+iFkiYWUBeYvOat8wTGAVmIVkxC6FqFpKqBYzMqxhFU0uTC4qT 0nON9IoTc4tL89L1kvNzNzFCYujrDsalx6wOMQpwMCrx8EZ8qg0VYk0sK67MPcQowcGsJMK7 hr8uVIg3JbGyKrUoP76oNCe1+BCjNAeLkjjvzF3vQ4QE0hNLUrNTUwtSi2CyTBycUg2MK6+t PcTE+v/u1V+9r7fZLTiUYhz4y4RZJ/Wo+6tPFc43Hk+8fty7pEV1J8eE0tMzuHJ/N/qrPnPZ kft3evWdHC/b9pxz4puaZX59MfJienUuJ7w5ecu679H6P0N3c8xhTraM5ZtvkLHflXnWhUlp /68UJnx5/pdn5+9sDt3DtoKX8143BU9bqMRSnJFoqMVcVJwIAGmDcvKdAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.06.2015 19:24, Anand Moon wrote: > This changes enables TMU IP block on the Exynos5422 Odroid-XU3 > device. > > Signed-off-by: Anand Moon > Tested-by: Markus Reichl This does not look right. You put this "Tested-by" since beginning of this patchset (v1) but first it was LDO10. Then you proposed LDO18 and now you use LDO7 from my suggestion. Which of this was tested by Markus because I cannot find his emails with it on LKML? Krzysztof > Acked-by: Lukasz Majewski > --- > Changes rebase on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung branch for-next > Changes from v5: Use LDO7 regulator instead of LD010. > > The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU. > > I think the schematics are missing some of details but it can be deducted that: > 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5 > pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]). > 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of > S2MPS11 PMIC. > 3. I confirmed with the Exynos5422 datasheet that these > VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES). > > So the LDO7 it is... but before using it there is a caveat. The LDO7 > is also connected to VDD of MIPI, HDMI and few more. So when you use > this regulator in TMU it may be turned off by TMU driver (e.g. during > unbind). In such case these other blocks also should be tested and > checked whether they take this regulator and enable it. > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+)