From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753723AbbFODwn (ORCPT ); Sun, 14 Jun 2015 23:52:43 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:53253 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752351AbbFODwd (ORCPT ); Sun, 14 Jun 2015 23:52:33 -0400 X-AuditID: cbfec7f5-f794b6d000001495-1f-557e4bfdbfa2 Message-id: <557E4BF9.7000808@samsung.com> Date: Mon, 15 Jun 2015 12:52:25 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Anand Moon Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Linux Kernel Subject: Re: [PATCHv6 2/4] ARM: dts: exynos5422-odroidxu3: Enable TMU at Exynos5422 base References: <1434277445-5243-1-git-send-email-linux.amoon@gmail.com> <1434277445-5243-2-git-send-email-linux.amoon@gmail.com> <557E136E.7090409@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e/4Vd2/3nWhBvvaNSzmHznHatH/ZiGr xblXKxktXr8wtOh//JrZYtPja6wWl3fNYbOYcX4fk8W6jbfYLW5f5rVYev0ik8WE6WtZLFr3 HmF34PVYM28No0dLcw+bx+W+XiaPnbPusnusXP6FzWPTqk42j81L6j36tqxi9Pi8SS6AM4rL JiU1J7MstUjfLoErY8nP46wF9wUrNmw/xNbAuIGvi5GTQ0LARKJ/ylc2CFtM4sK99UA2F4eQ wFJGiV3LP0M5TxklJu2dyg5SxSugJbFy6VdmEJtFQFXi453prCA2m4CxxOblS8AmiQpESLy9 fJIJol5Q4sfkeywgtoiAmsSVpytYQYYyCxxnlnjztB2sWVggSqLz40VmiG3PGSXO/+kG28Ap ECyx4vgeoG4OoA51iSlTckHCzALyEpvXvGWewCgwC8mOWQhVs5BULWBkXsUomlqaXFCclJ5r pFecmFtcmpeul5yfu4kREkVfdzAuPWZ1iFGAg1GJhzfiU22oEGtiWXFl7iFGCQ5mJRFeZeu6 UCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8M3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwrvo2mbcj 2Y+/8YZqxv/qJ32XJA4+TmPc/NrjxJviN8IJsZfLPq5KeqGUFGfNHe1x2TTpdGxbsEuhQPWx rfOOf94tzBi0bJf1rtuOzDuUD+e8O1P5frNqwLWekCavz1b5C/PWzj7c9LDmcc7J+pD5c+7M C7Q4ycWgsPlIsNwMBmbWojnnLGe7KbEUZyQaajEXFScCANaepGmeAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.06.2015 11:13, Anand Moon wrote: > hi Krzysztof > > On 15 June 2015 at 05:21, Krzysztof Kozlowski wrote: >> On 14.06.2015 19:24, Anand Moon wrote: >>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3 >>> device. >>> >>> Signed-off-by: Anand Moon >>> Tested-by: Markus Reichl >>> Acked-by: Lukasz Majewski >>> --- >>> Changes rebase on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung branch for-next >>> Changes from v5: Use LDO7 regulator instead of LD010. >>> >>> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU. >>> >>> I think the schematics are missing some of details but it can be deducted that: >>> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5 >>> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]). >>> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of >>> S2MPS11 PMIC. >>> 3. I confirmed with the Exynos5422 datasheet that these >>> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES). >>> >>> So the LDO7 it is... but before using it there is a caveat. The LDO7 >>> is also connected to VDD of MIPI, HDMI and few more. So when you use >>> this regulator in TMU it may be turned off by TMU driver (e.g. during >>> unbind). In such case these other blocks also should be tested and >>> checked whether they take this regulator and enable it. >> >> Why did you took my email and pasted it here? >> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/343702.html >> >> It is written now in first person so it pretends that you wrote this. >> You are actually doing this for second time - taking my >> reply and putting into commit message or changelog. Why? >> >> And where is proper changelog? >> > > Sorry: My intention was never to take credit on what your guidance and > your pointers. > I value ever input of your and try not to repeat the mistakes I am repeating. > I will send updated version soon. If you want to quote me, then it's fine. But please indicate that this is a quote. Thanks for resending. Later I'll give the patchset a try on my XU3-Lite. Best regards, Krzysztof