public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] ARM: Fix build if CLKDEV_LOOKUP is not configured
@ 2015-06-14 18:24 Guenter Roeck
  2015-06-15 10:35 ` Sudeep Holla
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2015-06-14 18:24 UTC (permalink / raw)
  To: Daniel Lezcano; +Cc: Thomas Gleixner, linux-kernel, Guenter Roeck, Sudeep Holla

mips:allmodconfig fails to build with

drivers/clocksource/timer-sp804.c:
	In function '__sp804_clocksource_and_sched_clock_init':
drivers/clocksource/timer-sp804.c:88:3: error:
	implicit declaration of function 'clk_get_sys'

because CLKDEV_LOOKUP is not configured and the driver depends on it.

Fixes: 0b7402dce445 ("ARM: 8366/1: move Dual-Timer SP804 driver to
	drivers/clocksource")
Cc: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 60d7d3d204d3..d2a26f1f30e9 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -144,7 +144,7 @@ config ARM_GLOBAL_TIMER
 
 config ARM_TIMER_SP804
 	bool "Support for Dual Timer SP804 module"
-	depends on GENERIC_SCHED_CLOCK
+	depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
 	select CLKSRC_MMIO
 	select CLKSRC_OF if OF
 
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] ARM: Fix build if CLKDEV_LOOKUP is not configured
  2015-06-14 18:24 [PATCH -next] ARM: Fix build if CLKDEV_LOOKUP is not configured Guenter Roeck
@ 2015-06-15 10:35 ` Sudeep Holla
  0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2015-06-15 10:35 UTC (permalink / raw)
  To: Guenter Roeck, Daniel Lezcano
  Cc: Sudeep Holla, Thomas Gleixner, linux-kernel@vger.kernel.org



On 14/06/15 19:24, Guenter Roeck wrote:
> mips:allmodconfig fails to build with
>
> drivers/clocksource/timer-sp804.c:
> 	In function '__sp804_clocksource_and_sched_clock_init':
> drivers/clocksource/timer-sp804.c:88:3: error:
> 	implicit declaration of function 'clk_get_sys'
>
> because CLKDEV_LOOKUP is not configured and the driver depends on it.
>

Thanks for the fix and sorry for missing this.

> Fixes: 0b7402dce445 ("ARM: 8366/1: move Dual-Timer SP804 driver to
> 	drivers/clocksource")
> Cc: Sudeep Holla <sudeep.holla@arm.com>

Looks good to me, but I think it should go via RMK tree as other changes
are going through that.

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

Regards,
Sudeep

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-15 10:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-14 18:24 [PATCH -next] ARM: Fix build if CLKDEV_LOOKUP is not configured Guenter Roeck
2015-06-15 10:35 ` Sudeep Holla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox