* serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE
@ 2015-06-15 12:45 Andreas Ruprecht
2015-06-16 8:47 ` Maxime Coquelin
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Ruprecht @ 2015-06-15 12:45 UTC (permalink / raw)
To: Maxime Coquelin
Cc: Chanwoo Choi, Peter Hurley, Vladimir Zapolskiy, Andy Shevchenko,
Greg Kroah-Hartman, linux-kernel, Stefan Hengelein,
Valentin Rothberg, Paul Bolle
Hi Maxime,
your commit 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver")
was merged into linux-next today (i.e., next-20150615), and contains the
following piece of code:
[...]
#if defined(CONFIG_SERIAL_STM32_USART_CONSOLE) &&
defined(CONFIG_MAGIC_SYSRQ)
#define SUPPORT_SYSRQ
#endif
[...]
The #if block can never be enabled as no symbol named
SERIAL_STM32_USART_CONSOLE is defined in Kconfig. Did you maybe mean
SERIAL_STM32_CONSOLE which you introduce in the same commit?
I detected the issue by running undertaker-checkpatch from the
Undertaker tool suite (https://undertaker.cs.fau.de). There is also a
tool in the Linux tree itself that can detect such issues
(scripts/checkkconfigsymbols.py).
Regards,
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE
2015-06-15 12:45 serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE Andreas Ruprecht
@ 2015-06-16 8:47 ` Maxime Coquelin
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Coquelin @ 2015-06-16 8:47 UTC (permalink / raw)
To: Andreas Ruprecht
Cc: Chanwoo Choi, Peter Hurley, Vladimir Zapolskiy, Andy Shevchenko,
Greg Kroah-Hartman, linux-kernel, Stefan Hengelein,
Valentin Rothberg, Paul Bolle
Hi Andreas,
2015-06-15 14:45 GMT+02:00 Andreas Ruprecht <andreas.ruprecht@fau.de>:
> Hi Maxime,
>
> your commit 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver")
> was merged into linux-next today (i.e., next-20150615), and contains the
> following piece of code:
>
> [...]
> #if defined(CONFIG_SERIAL_STM32_USART_CONSOLE) &&
> defined(CONFIG_MAGIC_SYSRQ)
> #define SUPPORT_SYSRQ
> #endif
> [...]
>
> The #if block can never be enabled as no symbol named
> SERIAL_STM32_USART_CONSOLE is defined in Kconfig. Did you maybe mean
> SERIAL_STM32_CONSOLE which you introduce in the same commit?
Yes, you a right, I meant SERIAL_STM32_CONSOLE.
I will prepare a fix.
>
> I detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (https://undertaker.cs.fau.de). There is also a
> tool in the Linux tree itself that can detect such issues
> (scripts/checkkconfigsymbols.py).
Ok thanks for the pointer! I didn't know these tools.
Regards,
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-16 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-15 12:45 serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE Andreas Ruprecht
2015-06-16 8:47 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox