From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755500AbbFONrV (ORCPT ); Mon, 15 Jun 2015 09:47:21 -0400 Received: from mail1.windriver.com ([147.11.146.13]:46064 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754083AbbFONrN (ORCPT ); Mon, 15 Jun 2015 09:47:13 -0400 Message-ID: <557ED6D9.1020109@windriver.com> Date: Mon, 15 Jun 2015 09:44:57 -0400 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jesper Nilsson CC: , Mikael Starvik , Jesper Nilsson , Subject: Re: [PATCH] cris: don't use module_init for non-modular core eeprom.c code References: <1434315921-1198-1-git-send-email-paul.gortmaker@windriver.com> <20150615073501.GO26605@axis.com> In-Reply-To: <20150615073501.GO26605@axis.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.56.57] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-06-15 03:35 AM, Jesper Nilsson wrote: > On Sun, Jun 14, 2015 at 05:05:21PM -0400, Paul Gortmaker wrote: >> The eeprom.c code is compiled based on the Kconfig setting >> ETRAX_I2C_EEPROM, which is bool. So the code is either built in >> or absent. It will never be modular, so using module_init as an >> alias for __initcall is rather misleading. >> >> Fix this up now, so that we can relocate module_init from >> init.h into module.h in the future. If we don't do this, we'd >> have to add module.h to obviously non-modular code, and that >> would be a worse thing. >> >> Direct use of __initcall is discouraged, vs prioritized ones. >> Use of device_initcall is consistent with what __initcall >> maps onto, and hence does not change the init order, making the >> impact of this change zero. Should someone with real hardware >> for boot testing want to change it later to arch_initcall or >> something different, they can do that at a later date. >> >> Cc: Mikael Starvik > > Looks good, I'll take it in the CRIS-tree. That is fine if you want, but I need to keep a copy here in this series (as per the part of the msg you snipped) ; otherwise I'll introduce a bisect fail into the commit history if my tree gets merged ahead of the cris tree. Thanks, Paul. -- > >> Cc: linux-cris-kernel@axis.com >> Signed-off-by: Paul Gortmaker > > /^JN - Jesper Nilsson >