From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754389AbbFOOMx (ORCPT ); Mon, 15 Jun 2015 10:12:53 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55483 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbbFOOMp (ORCPT ); Mon, 15 Jun 2015 10:12:45 -0400 Message-ID: <557EDD5B.5050703@suse.cz> Date: Mon, 15 Jun 2015 16:12:43 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jim Davis , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts/package/Makefile: rpmbuild is needed for rpm targets References: <1433794748-6570-1-git-send-email-jim.epost@gmail.com> In-Reply-To: <1433794748-6570-1-git-send-email-jim.epost@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-06-08 22:19, Jim Davis wrote: > Before rpm release 4.1, in 2002, either the rpm command or the > rpmbuild command could be used in the rpm-pkg or binrpm-pkg targets, > and the Makefile chose the rpm command if the rpmbuild command wasn't > found. > > After release 4.1, however, the rpm command could no longer be used in > place of the rpmbuild command. As the rpmbuild command is not > installed by default, this can lead to failures with the rpm-pkg and > binrpm-pkg targets: > > rpm --define "_builddir ." --target \ > x86_64 -bb ./binkernel.spec > rpm --target: unknown option > scripts/package/Makefile:60: recipe for target 'binrpm-pkg' failed > > Change the Makefile to use rpmbuild unconditionally to avoid this. > > Signed-off-by: Jim Davis I agree that compatibility with rpm < 4.1 is not an issue nowadays and "rpmbuild: command not found" is a lot more informative error message. I applied the patch to kbuild.git#misc. thanks, Michal