From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932334AbbFOTIR (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Jun 2015 15:08:17 -0400
Received: from bhuna.collabora.co.uk ([93.93.135.160]:58949 "EHLO
	bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756147AbbFOTHD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Jun 2015 15:07:03 -0400
Message-ID: <557F224F.7090102@collabora.co.uk>
Date: Mon, 15 Jun 2015 21:06:55 +0200
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0
MIME-Version: 1.0
To: kbuild test robot <fengguang.wu@intel.com>,
        Gwendal Grignou <gwendal@chromium.org>
CC: kbuild-all@01.org, Lee Jones <lee.jones@linaro.org>,
        Dmitry Torokhov <dtor@chromium.org>,
        Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH ljones-mfd] mfd: cros_ec:: ec_p can be static
References: <201506152112.lboOYuQR%fengguang.wu@intel.com> <20150615133939.GA240231@ivytown2>
In-Reply-To: <20150615133939.GA240231@ivytown2>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Fengguang,

Thanks a lot for your patch.

On 06/15/2015 03:39 PM, kbuild test robot wrote:
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  cros_ec.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index 11b1884b..dd6f4ff 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -27,7 +27,7 @@
>  #define CROS_EC_DEV_EC_INDEX 0
>  #define CROS_EC_DEV_PD_INDEX 1
>  
> -struct cros_ec_platform ec_p = {
> +static struct cros_ec_platform ec_p = {
>  	.ec_name = CROS_EC_DEV_NAME,
>  	.cmd_offset = EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_EC_INDEX),
>  };
> @@ -37,13 +37,13 @@ struct cros_ec_platform pd_p = {
>  	.cmd_offset = EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_PD_INDEX),
>  };

This can also be static

>  
> -struct mfd_cell ec_cell = {
> +static struct mfd_cell ec_cell = {
>  	.name = "cros-ec-ctl",
>  	.platform_data = &ec_p,
>  	.pdata_size = sizeof(ec_p),
>  };
>  
> -struct mfd_cell ec_pd_cell = {
> +static struct mfd_cell ec_pd_cell = {
>  	.name = "cros-ec-ctl",
>  	.platform_data = &pd_p,
>  	.pdata_size = sizeof(pd_p),
> 

These two should in fact be static const since mfd_add_devices()
expects a const struct mfd_cell * as third argument. I forgot on
my patch, sorry about that.

With these changes:

Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Best regards,
Javier