From: Caesar Wang <wxt@rock-chips.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: heiko@sntech.de, khilman@linaro.org, tomasz.figa@gmail.com,
ulf.hansson@linaro.org, dmitry.torokhov@gmail.com,
dianders@chromium.org, linux-rockchip@lists.infradead.org,
"jinkun.hong" <jinkun.hong@rock-chips.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sandeep Nair <sandeep_n@ti.com>, Flora Fu <flora.fu@mediatek.com>,
Arnd Bergmann <arnd@arndb.de>,
Stephen Warren <swarren@nvidia.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain driver
Date: Tue, 16 Jun 2015 10:00:30 +0800 [thread overview]
Message-ID: <557F833E.9000905@rock-chips.com> (raw)
In-Reply-To: <1434380419.2069.38.camel@x220>
在 2015年06月15日 23:00, Paul Bolle 写道:
> On Sun, 2015-06-14 at 13:13 +0800, Caesar Wang wrote:
>
>> --- /dev/null
>> +++ b/drivers/soc/rockchip/Kconfig
>> +config PM_GENERIC_DOMAINS
>> + tristate "Rockchip generic power domain"
> Since my remarks on v13 you removed the module specific code from
> pm_domains.c. But now this became a tristate symbol. That makes little
> sense. Why didn't you keep bool?
Yeah, you are right. :s/tristate/bool
I forget it when the driver is moving from 'arch/arm/mach-rockchip/' to
'/driver/soc/rockchip/'.
>
>> + depends on PM
>> + help
>> + Say y here to enable power doamin support.
> s/doamin/domain/.
Done.
>> + In order to meet high performance and low power requirements, a power
>> + management unit is designed or saving power when RK3288 in low power
>> + mode. The RK3288 PMU is dedicated for managing the power ot the whole chip.
> s/ot/of/
Done.
>> + If unsure, say N.
> Thanks,
>
>
> Paul Bolle
Thanks,
Caesar
>
>
>
--
Thanks,
- Caesar
next prev parent reply other threads:[~2015-06-16 2:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 5:13 [PATCH v15 0/4] ARM: rk3288: Add PM Domain support Caesar Wang
2015-06-14 5:13 ` [PATCH v15 1/4] dt-bindings: add document of Rockchip power domain Caesar Wang
2015-06-14 5:13 ` [PATCH v15 2/4] ARM: power-domain: rockchip: add the support type on RK3288 Caesar Wang
2015-06-14 5:13 ` [PATCH v15 3/4] soc: rockchip: power-domain: add power domain driver Caesar Wang
2015-06-15 15:00 ` Paul Bolle
2015-06-16 2:00 ` Caesar Wang [this message]
2015-06-14 5:13 ` [PATCH v15 4/4] ARM: dts: add RK3288 power-domain node Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557F833E.9000905@rock-chips.com \
--to=wxt@rock-chips.com \
--cc=arnd@arndb.de \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=flora.fu@mediatek.com \
--cc=heiko@sntech.de \
--cc=jinkun.hong@rock-chips.com \
--cc=khilman@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pdeschrijver@nvidia.com \
--cc=pebolle@tiscali.nl \
--cc=s.hauer@pengutronix.de \
--cc=sandeep_n@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@nvidia.com \
--cc=tomasz.figa@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox