From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751826AbbFPCAv (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Jun 2015 22:00:51 -0400
Received: from regular1.263xmail.com ([211.150.99.130]:53341 "EHLO
	regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750858AbbFPCAn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Jun 2015 22:00:43 -0400
X-263anti-spam: KSV:0;
X-MAIL-GRAY: 0
X-MAIL-DELIVERY: 1
X-KSVirus-check: 0
X-ABS-CHECKED: 4
X-ADDR-CHECKED: 0
X-RL-SENDER: wxt@rock-chips.com
X-FST-TO: linux-arm-kernel@lists.infradead.org
X-SENDER-IP: 58.22.7.114
X-LOGIN-NAME: wxt@rock-chips.com
X-UNIQUE-TAG: <19bf82e004394fc89090e775a1e733ec>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Message-ID: <557F833E.9000905@rock-chips.com>
Date: Tue, 16 Jun 2015 10:00:30 +0800
From: Caesar Wang <wxt@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Paul Bolle <pebolle@tiscali.nl>
CC: heiko@sntech.de, khilman@linaro.org, tomasz.figa@gmail.com,
        ulf.hansson@linaro.org, dmitry.torokhov@gmail.com,
        dianders@chromium.org, linux-rockchip@lists.infradead.org,
        "jinkun.hong" <jinkun.hong@rock-chips.com>,
        Santosh Shilimkar <santosh.shilimkar@ti.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Sascha Hauer <s.hauer@pengutronix.de>, Sandeep Nair <sandeep_n@ti.com>,
        Flora Fu <flora.fu@mediatek.com>, Arnd Bergmann <arnd@arndb.de>,
        Stephen Warren <swarren@nvidia.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain
 driver
References: <1434258820-26779-1-git-send-email-wxt@rock-chips.com>	 <1434258820-26779-4-git-send-email-wxt@rock-chips.com> <1434380419.2069.38.camel@x220>
In-Reply-To: <1434380419.2069.38.camel@x220>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



在 2015年06月15日 23:00, Paul Bolle 写道:
> On Sun, 2015-06-14 at 13:13 +0800, Caesar Wang wrote:
>
>> --- /dev/null
>> +++ b/drivers/soc/rockchip/Kconfig
>> +config PM_GENERIC_DOMAINS
>> +        tristate "Rockchip generic power domain"
> Since my remarks on v13 you removed the module specific code from
> pm_domains.c. But now this became a tristate symbol. That makes little
> sense. Why didn't you keep bool?

Yeah, you are right. :s/tristate/bool

I forget it when the driver is moving from 'arch/arm/mach-rockchip/' to 
'/driver/soc/rockchip/'.
>
>> +        depends on PM
>> +        help
>> +          Say y here to enable power doamin support.
> s/doamin/domain/.

Done.
>> +          In order to meet high performance and low power requirements, a power
>> +          management unit is designed or saving power when RK3288 in low power
>> +          mode. The RK3288 PMU is dedicated for managing the power ot the whole chip.
> s/ot/of/

Done.
>> +          If unsure, say N.
> Thanks,
>
>
> Paul Bolle

Thanks,

Caesar

>
>
>

-- 
Thanks,
- Caesar