From: Jiang Liu <jiang.liu@linux.intel.com>
To: bhelgaas@google.com, benh@kernel.crashing.org,
tglx@linutronix.de, mingo@kernel.org, rdunlap@infradead.org,
yinghai@kernel.org, linux-kernel@vger.kernel.org,
tony.luck@intel.com, ying.huang@intel.com,
konrad.wilk@oracle.com, hpa@zytor.com, bp@alien8.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/apic] genirq: Prevent crash in irq_move_irq()
Date: Tue, 16 Jun 2015 15:47:50 +0800 [thread overview]
Message-ID: <557FD4A6.7040301@linux.intel.com> (raw)
In-Reply-To: <tip-458526ec81d755dfaa17f3d863302afe6fbefca0@git.kernel.org>
On 2015/6/16 15:31, tip-bot for Jiang Liu wrote:
> Commit-ID: 458526ec81d755dfaa17f3d863302afe6fbefca0
> Gitweb: http://git.kernel.org/tip/458526ec81d755dfaa17f3d863302afe6fbefca0
> Author: Jiang Liu <jiang.liu@linux.intel.com>
> AuthorDate: Mon, 1 Jun 2015 16:05:11 +0800
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Tue, 16 Jun 2015 09:23:28 +0200
>
> genirq: Prevent crash in irq_move_irq()
>
> The functions irq_move_irq() and irq_move_masked_irq() expect that the
> caller passes the top-level irq_data to them when hierarchical
> irqdomains are enabled. But that's not true when called from
> apic_ack_edge(), which results in a null pointer dereference by
> idata->chip->irq_mask(idata).
>
> Instead of fixing callers to passing top-level irq_data, we rather
> change irq_move_irq()/irq_move_masked_irq() to accept any irq_data.
>
> Fixes: 52f518a3a7c 'x86/MSI: Use hierarchical irqdomains to manage MSI interrupts'
Hi Thomas,
This patch has dependency on patch "[Patch v3 01/36] genirq:
Enhance irq_data_to_desc() to support hierarchy irqdomain" in the
same patch set, otherwise irq_data_to_desc(idata) may return invalid
irq_desc and may cause memory crash.
Thanks!
Gerry
next prev parent reply other threads:[~2015-06-16 7:48 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 8:05 [Patch v3 00/36] Split struct irq_data into common part and per-chip part Jiang Liu
2015-06-01 8:05 ` [Patch v3 01/36] genirq: Enhance irq_data_to_desc() to support hierarchy irqdomain Jiang Liu
2015-06-16 8:16 ` [tip:x86/apic] " tip-bot for Jiang Liu
2015-06-20 17:18 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 02/36] genirq: Fix crash caused by irq_move_irq() when hierarch irqdomain is enabled Jiang Liu
2015-06-16 7:31 ` [tip:x86/apic] genirq: Prevent crash in irq_move_irq() tip-bot for Jiang Liu
2015-06-16 7:47 ` Jiang Liu [this message]
2015-06-16 8:12 ` Thomas Gleixner
2015-06-16 8:25 ` Jiang Liu
2015-06-16 8:16 ` tip-bot for Jiang Liu
2015-06-20 17:19 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 03/36] genirq: Introduce struct irq_common_data to host shared irq data Jiang Liu
2015-06-20 17:19 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 04/36] genirq: Introduce helper function irq_data_get_node() Jiang Liu
2015-06-20 17:19 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 05/36] x86, irq: Use accessor irq_data_get_node() to hide struct irq_data detail Jiang Liu
2015-06-01 8:05 ` [Patch v3 06/36] sh, " Jiang Liu
2015-06-01 8:05 ` [Patch v3 07/36] genirq: Move field 'node' from struct irq_data into struct irq_common_data Jiang Liu
2015-09-16 20:56 ` [tip:irq/urgent] genirq: Move field 'node' from irq_data into irq_common_data tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 08/36] sparc, irq: Use helper irq_data_get_irq_handler_data() to hide irq_desc details Jiang Liu
2015-07-31 21:53 ` [tip:irq/core] sparc/irq: Use helper irq_data_get_irq_handler_data() tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 09/36] x86, irq: Use helper irq_data_get_irq_handler_data() to hide irq_desc details Jiang Liu
2015-06-01 8:05 ` [Patch v3 10/36] " Jiang Liu
2015-06-01 8:05 ` [Patch v3 11/36] sh, " Jiang Liu
2015-06-01 11:38 ` Sergei Shtylyov
2015-06-01 13:53 ` Jiang Liu
2015-06-01 8:05 ` [Patch v3 12/36] genirq: Move field 'handler_data' from struct irq_data into struct irq_common_data Jiang Liu
2015-09-16 20:56 ` [tip:irq/urgent] genirq: Move field 'handler_data' from irq_data into irq_common_data tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 13/36] mn10300: Fix incorrect use of data->affinity Jiang Liu
2015-06-26 19:49 ` [tip:irq/urgent] mn10300: Fix incorrect use of irq_data->affinity tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 14/36] genirq: Introduce helper function irq_data_get_affinity_mask() Jiang Liu
2015-06-20 17:19 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 15/36] alpha, irq: Use access helper irq_data_get_affinity_mask() Jiang Liu
2015-06-01 8:05 ` [Patch v3 16/36] ARM, " Jiang Liu
2015-06-01 8:05 ` [Patch v3 17/36] ARM64, " Jiang Liu
2015-06-02 6:25 ` Hanjun Guo
2015-06-01 8:05 ` [Patch v3 18/36] blackfin, " Jiang Liu
2015-06-01 8:05 ` [Patch v3 19/36] IA64, " Jiang Liu
2015-06-01 8:05 ` [Patch v3 20/36] metag, " Jiang Liu
2015-06-01 8:05 ` [Patch v3 21/36] mips, " Jiang Liu
2015-06-05 8:46 ` Ralf Baechle
2015-06-01 8:05 ` [Patch v3 22/36] mn10300, " Jiang Liu
2015-07-31 21:53 ` [tip:irq/core] mn10300/irq: " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 23/36] parisc, irq: " Jiang Liu
2015-07-31 21:53 ` [tip:irq/core] parisc/irq: " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 24/36] powerpc, irq: " Jiang Liu
2015-09-15 15:47 ` [tip:irq/urgent] " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 25/36] sh, " Jiang Liu
2015-06-01 8:05 ` [Patch v3 26/36] sparc, " Jiang Liu
2015-07-31 21:54 ` [tip:irq/core] sparc/irq: " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 27/36] x86, irq: " Jiang Liu
2015-06-02 19:19 ` Thomas Gleixner
2015-06-03 1:53 ` Jiang Liu
2015-06-03 3:46 ` Jiang Liu
2015-06-01 8:05 ` [Patch v3 28/36] xtensa, " Jiang Liu
2015-06-01 8:05 ` [Patch v3 29/36] irqchip, " Jiang Liu
2015-07-11 21:38 ` [tip:irq/core] irqchip/mips-gic: " tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 30/36] net/mlx4: Cache irq_desc->affinity instead of irq_desc Jiang Liu
2015-06-01 8:05 ` [Patch v3 31/36] genirq: Move field 'affinity' from struct irq_data into struct irq_common_data Jiang Liu
2015-06-03 3:47 ` Jiang Liu
2015-09-16 20:56 ` [tip:irq/urgent] genirq: Move field 'affinity' from irq_data into irq_common_data tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 32/36] genirq: Rename irq_data_get_msi() as irq_data_get_msi_desc() Jiang Liu
2015-06-01 8:05 ` [Patch v3 33/36] genirq: Use helper function to access irq_data->msi_desc Jiang Liu
2015-06-02 3:45 ` [v3,33/36] " Michael Ellerman
2015-06-02 5:46 ` Jiang Liu
2015-06-03 16:53 ` Thomas Gleixner
2015-06-01 8:05 ` [Patch v3 34/36] genirq: Move field 'msi_desc' from struct irq_data into struct irq_common_data Jiang Liu
2015-09-16 20:57 ` [tip:irq/urgent] genirq: Move field 'msi_desc' from irq_data into irq_common_data tip-bot for Jiang Liu
2015-06-01 8:05 ` [Patch v3 35/36] genirq: Pass irq_data to helper function __irq_set_chip_handler_name_locked() Jiang Liu
2015-06-05 8:48 ` Ralf Baechle
2015-06-01 8:05 ` [Patch v3 36/36] genirq: Optimize irq_data_to_desc() to avoid irq_to_desc() lookup Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557FD4A6.7040301@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).