From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758815AbdEVKuv (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 May 2017 06:50:51 -0400
Received: from mout.web.de ([212.227.15.3]:52966 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757468AbdEVKut (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 May 2017 06:50:49 -0400
Subject: Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory
 allocations in five functions
To: Stefan Hajnoczi <stefanha@gmail.com>, kvm@vger.kernel.org,
        netdev@vger.kernel.org, virtualization@lists.linux-foundation.org,
        kernel-janitors@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, Wolfram Sang <wsa@the-dreams.de>
References: <bafa65e4-08fe-efdb-d836-7657e8a64749@users.sourceforge.net>
 <babc429d-6440-92aa-e1d0-eee2636a8d0f@users.sourceforge.net>
 <20170522094320.GE12205@stefanha-x1.localdomain>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <557bdff4-6dc2-756d-0d59-9f688ef11f0a@users.sourceforge.net>
Date: Mon, 22 May 2017 12:50:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170522094320.GE12205@stefanha-x1.localdomain>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:tq7BkCMj39Pn+Id0PNUdAPx2JZzNfsQfMFfYIY8uzJbGg2s7nll
 9+C6fXovTIIDUKc9+qumdoaiZwxcwRzl4ta4UPiLmgJGoVBJeAqN95l/iTmrgc+AXfuDu5G
 SSr/uWdqyZjARSyaTNZHEV7PvmwSzVJpEeMY2mzBOOClMT173SBRBmlQTnk17XnvySq+ZxF
 wqMuC5J9HK4FBOhN65KMA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:+4hqZswdO7E=:th/DEvWj2p5i4evBEEc6FE
 62yfHglx2VVGIRrsqnD7vkin9QDCjSwrhmRFS3xjpHB3P7w8Zat3zQHiCbZKGU5N22bgqdovW
 jgOnTR9JpFtzcV+2jtvqVfYwTRKiccw611MaeHW1C5u3soSHaQ5qhCL2WM/cL61jyE6Mjvp42
 QWdpuelO6SRaopUyHRASq84IBYd9RtQgNjq82C4vvm+HK+zxf3R2Nr6HkDB60af5UkUzW1lP6
 pzE31isV6H+RZzHXQVg4iMO1O/KleiHWhYrG2UGWLSfs6CHfKCPiiNhClXwsQ2Cu6Fqg/QtUo
 5iqkgIqrusxgFKqerLv+Cn10qMktzIesnVuQs/lsE7R7rE1vWzlvqO2gK9r9ZjbSx7d8ddduL
 qIkWhun+8KszYLOL6HeRZpwNDE8+pvDEzD5nd7zZUzGH7t3SV0IRxaoFMyTkxkjy/lTa7EPSs
 GdQ2XeYKBsZvS/z88y4+bE0S7n7HvMbZLno3dj4tapRM0obOj8zINC1OGchI7rgtuT8cHtl6x
 l0uO8ifBW5MgraUzrKiBNy55AEzo2IW1F9tAdPZdlt1qx2TsZM1FyryQoT0pqWIgasrToZk9Y
 adtjS30tOAls6PEKKAtXKv3cy0Ml+tOl7JjZW8nkLKewjD0/PsPbyK0AU+5FHxkkamlWKPqKZ
 UwN+rLHdsuoskkE5nf3qvWBY5Qkm+Y472tYGVfilphMhftgnmWsSJMT2Vy0+Br9eW9z+sCfT5
 3wg39KPP9Mi5E0Dmzd3JgVghiWuhCIQdsB6+ixqCouyImc0SnD/z43h6iyhQ1gVOENv2m0blq
 OiZVMt+
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> 
> Please include an actual explanation for this change instead of linking
> to slides.

Do you care for a bit of code size reduction by removal of questionable
error messages?


> Why are you trying to get rid of memory allocation failure messages?

Do you find information from a Linux allocation failure report sufficient
for any function implementations here?


>> +++ b/drivers/vhost/scsi.c
>> @@ -417,5 +417,4 @@ vhost_scsi_allocate_evt(struct vhost_scsi *vs,
>>  	if (!evt) {
>> -		vq_err(vq, "Failed to allocate vhost_scsi_evt\n");
> 
> #define vq_err(vq, fmt, ...) do {                                  \
>                 pr_debug(pr_fmt(fmt), ##__VA_ARGS__);       \
>                 if ((vq)->error_ctx)                               \
>                                 eventfd_signal((vq)->error_ctx, 1);\
>         } while (0)
> 
> You silently dropped the eventfd_signal() call.

Do you prefer to preserve this special error handling then?

Regards,
Markus