From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tristram.Ha@microchip.com, krzk+dt@kernel.org
Cc: davem@davemloft.net, conor+dt@kernel.org, edumazet@google.com,
robh@kernel.org, olteanv@gmail.com, f.fainelli@gmail.com,
andrew@lunn.ch, devicetree@vger.kernel.org,
UNGLinuxDriver@microchip.com, Woojung.Huh@microchip.com,
kuba@kernel.org, pabeni@redhat.com, marex@denx.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII port support to KSZ9477 switch
Date: Wed, 14 Aug 2024 08:12:50 +0200 [thread overview]
Message-ID: <557edcbd-28ad-4e0e-a891-8bac8e2f3e53@kernel.org> (raw)
In-Reply-To: <BYAPR11MB355819407FDCD6E1E601BB33EC862@BYAPR11MB3558.namprd11.prod.outlook.com>
On 14/08/2024 01:09, Tristram.Ha@microchip.com wrote:
>> On 10/08/2024 01:38, Tristram.Ha@microchip.com wrote:
>>> From: Tristram Ha <tristram.ha@microchip.com>
>>>
>>> The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct
>>> connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP.
>>
>> Binding should say it, not commit msg. But aren't you duplicating
>> something like phy-connection-type?
>
> The sgmii-mode parameter is just used internally. I am not sure using
This does not matter.
> phy-connection-type or phy-mode is appropriate.
Depends on what this property expressed in terms of hardware. Looks like
you want to say which SGMII mode is being used?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-14 6:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 23:38 [PATCH net-next 0/4] net: dsa: microchip: add SGMII port support to KSZ9477 switch Tristram.Ha
2024-08-09 23:38 ` [PATCH net-next 1/4] dt-bindings: " Tristram.Ha
2024-08-10 0:20 ` Rob Herring (Arm)
2024-08-10 11:48 ` Krzysztof Kozlowski
2024-08-13 23:09 ` Tristram.Ha
2024-08-14 6:12 ` Krzysztof Kozlowski [this message]
2024-08-14 22:32 ` Tristram.Ha
2024-08-10 17:26 ` Andrew Lunn
2024-08-13 21:14 ` Tristram.Ha
2024-08-13 21:32 ` Andrew Lunn
2024-08-13 22:17 ` Tristram.Ha
2024-08-14 13:50 ` Andrew Lunn
2024-08-14 22:30 ` Tristram.Ha
2024-08-14 22:40 ` Andrew Lunn
2024-08-15 21:54 ` Tristram.Ha
2024-08-15 22:50 ` Andrew Lunn
2024-08-09 23:38 ` [PATCH net-next 2/4] net: dsa: microchip: support global switch interrupt in KSZ DSA driver Tristram.Ha
2024-08-09 23:38 ` [PATCH net-next 3/4] net: dsa: microchip: handle most interrupts in KSZ9477/KSZ9893 switch families Tristram.Ha
2024-08-10 17:43 ` Sai Krishna Gajula
2024-08-10 17:44 ` Andrew Lunn
2024-08-13 22:24 ` Tristram.Ha
2024-08-14 13:55 ` Andrew Lunn
2024-08-09 23:38 ` [PATCH net-next 4/4] net: dsa: microchip: add SGMII port support to KSZ9477 switch Tristram.Ha
2024-08-10 17:52 ` Andrew Lunn
2024-08-13 20:59 ` Tristram.Ha
2024-08-11 16:32 ` Andrew Lunn
2024-08-13 20:54 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557edcbd-28ad-4e0e-a891-8bac8e2f3e53@kernel.org \
--to=krzk@kernel.org \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox