public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Orestes Leal Rodriguez <lukes357@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: mihai.dontu@gmail.com
Subject: [PATCH 1/1] lib: small update for strlen, strnlen, use less cpu instructions
Date: Tue, 16 Jun 2015 13:50:16 -0500	[thread overview]
Message-ID: <55806FE8.9030302@gmail.com> (raw)

Very small update to strlen and strnlen that now use less cpu 
instructions by using a counter to avoid the memory addresses 
substraction to find the length of the string.

Signed-off-by: Orestes Leal Rodriguez <lukes357@gmail.com>
---

diff --git a/lib/string.c" "b/lib/string.c
index 992bf30..c873436 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -17,6 +17,10 @@
   * * Sat Feb 09 2002, Jason Thomas <jason@topic.com.au>,
   *                    Matthew Hawkins <matt@mh.dropbear.id.au>
   * -  Kissed strtok() goodbye
+ *
+ * * Tuesday June 16 2015, Orestes Leal Rodriguez <lukes357@gmail.com>
+ * - strlen, strnlen: by using a single counter we use less cpu 
instructions
+ *   by avoiding substracting the memory addresses before return
   */

  #include <linux/types.h>
@@ -401,11 +405,11 @@ EXPORT_SYMBOL(strim);
   */
  size_t strlen(const char *s)
  {
-	const char *sc;
+	size_t sz = 0;

-	for (sc = s; *sc != '\0'; ++sc)
-		/* nothing */;
-	return sc - s;
+	for (; *s++ != '\0'; sz++)
+		/* empty */;
+	return sz;
  }
  EXPORT_SYMBOL(strlen);
  #endif
@@ -418,12 +422,13 @@ EXPORT_SYMBOL(strlen);
   */
  size_t strnlen(const char *s, size_t count)
  {
-	const char *sc;
+	size_t sz = 0;

-	for (sc = s; count-- && *sc != '\0'; ++sc)
-		/* nothing */;
-	return sc - s;
+	for (; count-- && *s++ != '\0'; sz++)
+		/* empty */;
+	return sz;
  }
+
  EXPORT_SYMBOL(strnlen);
  #endif



             reply	other threads:[~2015-06-16 17:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 18:50 Orestes Leal Rodriguez [this message]
2015-06-16 22:16 ` [PATCH 1/1] lib: small update for strlen, strnlen, use less cpu instructions Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2015-06-16 18:51 Orestes Leal Rodriguez
2015-06-16 22:51 Orestes Leal Rodriguez
2015-06-17 20:07 ` Richard Weinberger
2015-06-19  3:11   ` Orestes Leal Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55806FE8.9030302@gmail.com \
    --to=lukes357@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.dontu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox