From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>, Eric Hankland <ehankland@google.com>
Cc: rkrcmar@redhat.com, linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: PMU Event Filter
Date: Wed, 17 Jul 2019 12:22:23 +0200 [thread overview]
Message-ID: <5580889b-e357-e7bc-88e6-d68c4a23dd64@redhat.com> (raw)
In-Reply-To: <5D2D8FB4.3020505@intel.com>
On 16/07/19 10:49, Wei Wang wrote:
> {
> KVM_PMU_EVENT_ACTION_GP_NONE = 0,
> KVM_PMU_EVENT_ACTION_GP_ACCEPT = 1,
> KVM_PMU_EVENT_ACTION_GP_REJECT = 2,
> KVM_PMU_EVENT_ACTION_MAX
> };
>
> and add comments to explain something like below:
>
> Those GP actions are for the filtering of guest events running on the
> virtual general
> purpose counters. The actions to filter guest events running on the
> virtual fixed
> function counters are not added currently as they all seem fine to be
> used by the
> guest so far, but that could be supported on demand in the future via
> adding new
> actions.
>
Let's just implement the bitmap of fixed counters (it's okay to follow
the same action as gp counters), and add it to struct
kvm_pmu_event_filter. While at it, we can add a bunch of padding u32s
and a flags field that can come in handy later (it would fail the ioctl
if nonzero).
Wei, Eric, who's going to do it? :)
Paolo
next prev parent reply other threads:[~2019-07-17 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 1:25 [PATCH v2] KVM: x86: PMU Event Filter Eric Hankland
2019-07-11 11:22 ` Paolo Bonzini
2019-07-11 11:58 ` Paolo Bonzini
2019-07-11 17:04 ` Eric Hankland
2019-07-11 17:12 ` Paolo Bonzini
2019-07-12 3:27 ` Wei Wang
2019-07-16 0:10 ` Eric Hankland
2019-07-16 8:49 ` Wei Wang
2019-07-17 10:22 ` Paolo Bonzini [this message]
2019-07-17 17:05 ` Eric Hankland
2019-07-17 17:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5580889b-e357-e7bc-88e6-d68c4a23dd64@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehankland@google.com \
--cc=eranian@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox