Re: [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix

Re: [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix

[Tordek]

>  Thanks, but it's also fixed by commit 8b4e7da516aa in linux-next.

I see. Thank you and Sudip for your feedback, I'll look into the proper branches next time!

-- 
Guillermo O. «Tordek» Freschi
http://tordek.me :: http://twitter.com/tordek

[PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix

[Guillermo O. Freschi]

Removed some spaces before a tab character.

Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
---
 drivers/staging/comedi/drivers/pcl816.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
index 1ccb2f1..781b321 100644
--- a/drivers/staging/comedi/drivers/pcl816.c
+++ b/drivers/staging/comedi/drivers/pcl816.c
@@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
 
 		/*  check whole chanlist */
 		for (i = 0, segpos = 0; i < chanlen; i++) {
-			    if (chanlist[i] != chansegment[i % seglen]) {
+			if (chanlist[i] != chansegment[i % seglen]) {
 				dev_dbg(dev->class_dev,
 					"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
 					i, CR_CHAN(chansegment[i]),
-- 
2.1.4

Re: [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix

[Ian Abbott]

On 16/06/15 12:56, Guillermo O. Freschi wrote:
> Removed some spaces before a tab character.
>
> Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
> ---
>   drivers/staging/comedi/drivers/pcl816.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
> index 1ccb2f1..781b321 100644
> --- a/drivers/staging/comedi/drivers/pcl816.c
> +++ b/drivers/staging/comedi/drivers/pcl816.c
> @@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
>
>   		/*  check whole chanlist */
>   		for (i = 0, segpos = 0; i < chanlen; i++) {
> -			    if (chanlist[i] != chansegment[i % seglen]) {
> +			if (chanlist[i] != chansegment[i % seglen]) {
>   				dev_dbg(dev->class_dev,
>   					"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
>   					i, CR_CHAN(chansegment[i]),
>

Thanks, but it's also fixed by commit 8b4e7da516aa in linux-next.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Re: [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix

[Sudip Mukherjee]

On Tue, Jun 16, 2015 at 08:56:40AM -0300, Guillermo O. Freschi wrote:
> Removed some spaces before a tab character.
> 
> Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
I should have checked when you sent your v1. This patch will not apply.
This change has already been done by commit:
8b4e7da51 ("staging: comedi/drivers/pcl.* coding style fixes")

please create your patches based on staging-testing tree.
and always use scripts/get_maintainer.pl to get a list of people and
mailing lists to send your patch.

regards
sudip