From: "long.wanglong" <long.wanglong@huawei.com>
To: Joe Perches <joe@perches.com>
Cc: <rjw@rjwysocki.net>, <lenb@kernel.org>, <ying.huang@intel.com>,
<tony.luck@intel.com>, <bp@suse.de>, <gong.chen@linux.intel.com>,
<tomasz.nowicki@linaro.org>, <lv.zheng@intel.com>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<wanglong@laoqinren.net>, <peifeiyue@huawei.com>
Subject: Re: [PATCH 2/2] apei/erst-dbg: Define pr_fmt macro to avoid the duplication of ERST_DBG_PFX
Date: Wed, 17 Jun 2015 09:31:16 +0800 [thread overview]
Message-ID: <5580CDE4.4090300@huawei.com> (raw)
In-Reply-To: <1434379353.2507.52.camel@perches.com>
On 2015/6/15 22:42, Joe Perches wrote:
> On Mon, 2015-06-15 at 09:57 +0000, Wang Long wrote:
>> Define pr_fmt macro with {ERST DBG: } prefix, then remove all use
>> of ERST_DBG_PFXin the pr_* functions.
> []
>> diff --git a/drivers/acpi/apei/erst-dbg.c b/drivers/acpi/apei/erst-dbg.c
> []
>> @@ -31,7 +31,8 @@
>>
>> #include "apei-internal.h"
>>
>> -#define ERST_DBG_PFX "ERST DBG: "
>> +#undef pr_fmt
>> +#define pr_fmt(fmt) "ERST DBG: " fmt
>
> Moving this #define above the first #include is what's
> generally done and doesn't require an #undef
>
OK, Thanks
>
>
> .
>
prev parent reply other threads:[~2015-06-17 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 9:57 [PATCH 1/2] apei/*.c: use pr_warn instead of pr_warning Wang Long
2015-06-15 9:57 ` [PATCH 2/2] apei/erst-dbg: Define pr_fmt macro to avoid the duplication of ERST_DBG_PFX Wang Long
2015-06-15 14:42 ` Joe Perches
2015-06-17 1:31 ` long.wanglong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5580CDE4.4090300@huawei.com \
--to=long.wanglong@huawei.com \
--cc=bp@suse.de \
--cc=gong.chen@linux.intel.com \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=peifeiyue@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=tomasz.nowicki@linaro.org \
--cc=tony.luck@intel.com \
--cc=wanglong@laoqinren.net \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox