From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757434AbbFQCqo (ORCPT ); Tue, 16 Jun 2015 22:46:44 -0400 Received: from mga01.intel.com ([192.55.52.88]:50219 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752723AbbFQCqh (ORCPT ); Tue, 16 Jun 2015 22:46:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,629,1427785200"; d="scan'208";a="589262768" Message-ID: <5580DF86.3010502@intel.com> Date: Tue, 16 Jun 2015 19:46:30 -0700 From: Tadeusz Struk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Herbert Xu CC: David Howells , linux-kernel@vger.kernel.org, keescook@chromium.org, jwboyer@redhat.com, smueller@chronox.de, richard@nod.at, steved@redhat.com, qat-linux@intel.com, linux-crypto@vger.kernel.org, james.l.morris@oracle.com, jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net, vgoyal@redhat.com Subject: Re: [PATCH RFC v7 2/3] crypto: rsa: add a new rsa generic implementation References: <20150616173101.1248.55033.stgit@tstruk-mobl1> <20150616173050.1248.21847.stgit@tstruk-mobl1> <18687.1434492657@warthog.procyon.org.uk> <5580DC30.4030301@intel.com> <20150617023630.GA7791@gondor.apana.org.au> In-Reply-To: <20150617023630.GA7791@gondor.apana.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2015 07:36 PM, Herbert Xu wrote: > The existing crypto/asymmetric_key errno scheme doesn't really > mesh in with the rest of crypto. So you'll just have to pick one > scheme and stick with it. > > I don't really mind either way as long as the error codes are > unique and meaningful. So I would use -EINVAL since these are input parameters. Do you agree David?