From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbbFRHF6 (ORCPT ); Thu, 18 Jun 2015 03:05:58 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:56354 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562AbbFRHFs (ORCPT ); Thu, 18 Jun 2015 03:05:48 -0400 Message-ID: <55826D9D.2060106@i2se.com> Date: Thu, 18 Jun 2015 09:05:01 +0200 From: Stefan Wahren User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Srinivas Kandagatla CC: Caesar Wang , heiko@sntech.de, mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, galak@codeaurora.org, matthias.bgg@gmail.com, jay.xu@rock-chips.com, linux-arm-kernel@lists.infradead.org, Maxime Ripard Subject: Re: [PATCH v2 0/3] Add the efuse driver on rockchip platform References: <1434439665-27781-1-git-send-email-wxt@rock-chips.com> <557FE3EA.4000306@i2se.com> <557FEAB2.1040101@linaro.org> <557FF50C.10809@rock-chips.com> <55800070.5030509@linaro.org> In-Reply-To: <55800070.5030509@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:T0O56Hw7ChP041WwEdJu/BSAvtDf+wQep6OhZAEpfVww8rSnTP2 GexB5fpZA7TEhnICsRwQETYlMJDZcBkB+mbCIE+l99H2ZmarQ3Tl8gj5yqzqNKBwGP1VKSS GvC6Azrghfch048W54iKtoOzwJdzeXfCnH6zTV6CuAeuICjiBTwYgUlC/LuWjqBS8Im2o4N nWtK3+1Sa37u0aLeIhNJg== X-UI-Out-Filterresults: notjunk:1;V01:K0:te6q9aXCh94=:Rs28AX7IO2O5w2NaKkEA80 5ZL4kQ0vrqySOuCZb+dEpUgB8nGl4G1JpiIGJULHzuenxXZXDaizz97s64jMLDQdbcgH/gvtD UmpMweXuVqssUDHzJOulLtQiUM3n2WmjlweJPsbCDOYQLpKGXOn6av579DUuvxeJQJM2refGt VfpCBQZmK9s9bhbgY0Qy+etwqkE4ss3s3CKYF7zi2QBYDCWnsKQ8AjWHjvZd2weT8J0OFtGYc Dib4FYq4yaQytMr6BFci0pUh3BnGpXwFRnCvYCJzi2Gj6BJMd7zbg7SkL2zd55nlzbtjeARZs MvfucbodJ4v5epYLtMwmNPmu8IvnRtDRaTeSD4cu+RwnROJU5B67Qg05hW9KREfKTrkH+Y/Ox /flO97UJxDhnpKVkYSVi6YG7Tb0db2auniHf1DV9wzaDaG/6FXWqZNNJF1jgXwK0J7YxM4gON rfGv9Xerruz2wAwJGpMQTr4/dupW1F7X73kM8Rri+lrym+ZkrYnAvryiEA86+dnXfnlPzS+dJ SQA7vbTyY751k5yXrBGPKMuHwNkHL4IWkLKdeUkAC9/6QcgYAdKOZRpwHhpky5NbeqnYSeKGX HqYHfMCFe9nPE/tOGebV6L00N5q5KoGK3ZbNjXTj3N+rfgReyDjhGo1OTmpOY7oEtXS8kFRIZ lnLmWONE3wTgqdhZcqviMNf5YjQ9EpZqr4r439a+OgaJltg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srinivas, Am 16.06.2015 um 12:54 schrieb Srinivas Kandagatla: > > > On 16/06/15 11:06, Caesar Wang wrote: >> Hi Srinivas, >> >> 在 2015年06月16日 17:21, Srinivas Kandagatla 写道: >>> Hi Stefan, >>> >>> >>> On 16/06/15 09:52, Stefan Wahren wrote: >>>> Hi Caesar, >>>> >>>> [add Maxime and Srinivas] >>>> >>>> Am 16.06.2015 um 09:27 schrieb Caesar Wang: >>>>> The original driver is uploaded by Jianqun. >>>>> Here is his patchs: >>>>> https://patchwork.kernel.org/patch/5410341/ >>>>> https://patchwork.kernel.org/patch/5410351/ >>>>> >>>>> Jianqun, nevermind! >>>>> I check-pick it and re-upload the driver for the upstream. >>>>> e.g.: >>>>> Tested by on minnie board.(kernel-4.1-rc8) >>>>> cd /sys/devices/platform/ffb40000.efuse >>>>> localhost ffb40000.efuse # cat cpu_leakage_show >>>>> cpu_version_show >>>>> The results: >>>>> 19 >>>>> 2 >>>>> >>>>> Changes in v2: >>>>> - Change the document decription. >>>>> - Move the efuse driver into driver/soc/vendor. >>>>> - update the efuse driver. >>>>> - Add the dts node on RK3288. >>>>> >>>>> >>>> >>>> i want to mention that there is a upcoming new framework suitable for >>>> efuse drivers: >>>> >>>> https://lkml.org/lkml/2015/5/21/643 >>>> >>>> Unfortunately i don't know the current development state. >>>> >>> >>> Currently this framework is used by atleast 3 drivers(qcom-tsens, >>> qcom-cpr, begel-bone-cape manager) which are still floating in the >>> mailing list. >>> >>> I was hoping that these 3 users would getback with tested-by.. which >>> did not happen for last 3-4 weeks. >>> >>> I would appreciate, If you could try framework too, and let me know. >> yes i work on OCOTP driver for MXS platform and i will try ... > > int rockchip_efuse_reg_read(void *context, unsigned int reg, unsigned > int *val) > { > /* efuse specific read sequence */ > ... > } I will need a specific read sequence too. Sorry for these newbie questions: What data structure does context points to for this reg_read opteration? Do we need range checking of reg or is it handled by the framework? Are there any limitation for reg_read regarding sleeping or locking operations? In case of a read only driver, is everything handle by devicetree or do we need an empty write operation? Best regards Stefan