From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: ext York Sun <yorksun@freescale.com>, wsa@the-dreams.de
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Peter Korsgaard <peter.korsgaard@barco.com>
Subject: Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg
Date: Thu, 18 Jun 2015 09:58:22 +0200 [thread overview]
Message-ID: <55827A1E.4020608@nokia.com> (raw)
In-Reply-To: <5581A3CA.4050805@freescale.com>
Hello!
On 17/06/15 18:43, ext York Sun wrote:
>> > Yeah, this is really bad idea. You maybe want something like
>> > __iomem "cookie" here instead of this bare pointer.
> Let me try.
>
Could you think about different access widths, please?
Not all buses are 32-bits wide and even on 64-bit CPUs one might have 16-bit bus
and 32 bits accesses are not allowed or perform two accesses, etc...
So to cover the use-cases which I see one needs to have a possibility to select between
__raw_writeb()/__raw_writew()/__raw_writel()/__raw_writeq() (now that I'm thinking about
it, I think these native-Endianness functions are preferred and if one has a bus with
different Endianness he should think about the conversion in the reg property of subnodes).
Very important is readback with corresponding __raw_read*(), but maybe you want to do
this optional via additional DT property...
--
Best regards,
Alexander Sverdlin.
next prev parent reply other threads:[~2015-06-18 7:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 17:28 [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg York Sun
2015-06-17 8:54 ` Paul Bolle
2015-06-17 15:00 ` Alexander Sverdlin
2015-06-17 16:03 ` Paul Bolle
2015-06-18 7:40 ` Alexander Sverdlin
2015-06-18 8:08 ` Paul Bolle
2015-06-18 9:04 ` Alexander Sverdlin
2015-06-18 9:32 ` Paul Bolle
2015-06-18 9:42 ` Alexander Sverdlin
2015-06-18 9:55 ` Paul Bolle
2015-06-17 15:03 ` Alexander Sverdlin
2015-06-17 16:43 ` York Sun
2015-06-18 7:58 ` Alexander Sverdlin [this message]
2015-08-15 20:23 ` Wolfram Sang
2015-08-17 16:37 ` York Sun
2015-08-18 16:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55827A1E.4020608@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.korsgaard@barco.com \
--cc=wsa@the-dreams.de \
--cc=yorksun@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox