From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755208AbbFRLZN (ORCPT ); Thu, 18 Jun 2015 07:25:13 -0400 Received: from mail-bn1bon0088.outbound.protection.outlook.com ([157.56.111.88]:59200 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754705AbbFRLZI (ORCPT ); Thu, 18 Jun 2015 07:25:08 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; socionext.com; dkim=none (message not signed) header.d=none; Message-ID: <5582AA80.8090603@xilinx.com> Date: Thu, 18 Jun 2015 13:24:48 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Masahiro Yamada , CC: =?windows-1252?Q?S=F6ren_Brinkmann?= , "Michal Simek" , Linus Walleij , , Alexandre Courbot , Subject: Re: [PATCH] gpio: zynq: add missing module_exit function References: <1434531101-2585-1-git-send-email-yamada.masahiro@socionext.com> In-Reply-To: <1434531101-2585-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD006;1:NPeGRsWQLd547PAksYjBWbkmgNAWwNlZWPy9Xcnm8vf9A+89eEWpdDo0Qt9pwvS+IuFap9WIPb7N/spXDpBLb2F45w/iVXyKJJux5PW2ogobadBFo7CA+QSBvW2H27Ugl+8WYZaVetTI7z1lTJSiTEQObAjPEzLbKduKf6atA2/HrXYyd8YSpQkPV1+hOC7UkzWKeN3r/0T+0kE6vHo/36d474c6xhp7aGcgSnAN1OQpHLClJtWSerCwCOmygjB3powm6BP4j6zLxNj53mXE2ZTqW50/Jnmu40aMHjM1HZ8= X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(479174004)(24454002)(377454003)(199003)(189002)(164054003)(51704005)(64126003)(33656002)(46102003)(83506001)(6806004)(87936001)(62966003)(77156002)(23746002)(2950100001)(63266004)(80316001)(4001350100001)(59896002)(5001770100001)(189998001)(36756003)(5001920100001)(5001960100002)(50466002)(65956001)(65806001)(36386004)(76176999)(47776003)(19580395003)(86362001)(19580405001)(77096005)(65816999)(87266999)(54356999)(50986999)(92566002)(106466001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB021;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:ovrnspm;A:1;MX:1;PTR:unknown-60-83.xilinx.com;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB021;2:85W40WQLasRHmeYeraXn0QCginp7ETMdS6mgXlisMkBqAjWv/048DhJI1n9/zO2Q;2:Jt1blrhjigcCV7QiL9VYFdhe3tj0d8qQlFBdIlcFanUsU6JxHAH3NWJDhZBla4PQOPAej4VOFJ0Pje0Zq6kTs0wx+cAMoEVX88PpRmh+meVceij/S4f4ApGAILooHB2JyxxW1lCoEJy/GBxp5lxp2Oetr9uxWSPJRW8dXqzffGcOBzQ5xfu4lrrvNZylbGnT8/4SgyRswnmGgBbJajGPXfi6mut7uT2qBKCqBgqiNrs=;6:/Sk8d9uAW/YN6Gx0NFruD3z3PNOGN/74SlKVYe5w4Oq3iRY4AwY8ME3mHQ3Y97dlD9Kfo0uQN03UNrL8UeDBy/Juy68kXgLLpFenWP2XCiAsorl8m4qw0ySgxqFNCIjd6n1mk5EEQiBWVCepvqaK/NRTJ/gkTInocg8oKrWBTd1qZwvg53KabAlm3V0ha9OvB1rIEilxTosRuzPeTtcGcnEW1z0gPB7IflDpGjPYv4gkQbzqGxvU6QxFTuKzxUVdGhkwbDnZA7ms77P/12x9nZXl8yZ+jAMnBDvQ6VvJvhfcn3Oj0rECM1Hyq61++mmvMXXmDeSR2auTErOGN81Yo7lDBC4fHt9P5y6TL07EpZ+YfW46SDyeDgpF9qgRf85b0kAtQCK9tv1UFok60Ig+3Ms0EsG0Vg/vADBxQHXPsEARhIgNmsvPmUpyUJmHVetVcttI9Z9aLmjIH4Y4heD9/nosRoAdLlyQZMqq21+i3drVPW0xQENktw5SgqHy2HNF X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB021; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BL2FFO11HUB021;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB021; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB021;3:sntAMPfOIGpH4YRb0Zc01IB2ZBqp1om82GuLnU0DoKzDh8ozUKox8EGUy4a5jG+x9fRWHaY2UFzzF6mLBSXI9/8VLSro4T/4fb3Sxl2OkNHNZ06aQQ/dcgZTxRXN2jrRJUvNvJTFuTfdJJFZ7OIIInGxgEDezWUxMMUKDA3d//+NQyskK8CedvW8qaCpX6mpnBZVD47ZJjnk1R2HGXcyljjLTdckJSCIe/PgBTg/eObgsNqFKc6Tk0IsTjgnZ/uyErPjXnPOHDYYTfmzxjC7xSl2SX3LKYd83+LWSPpLi9DcEYPIRtipuXzL0iBSOkts X-Forefront-PRVS: 0611A21987 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BL2FFO11HUB021;9:ogAl4lbgRu/y7xD7/7YRKXOT0UnKr2+ZsLHht?= =?Windows-1252?Q?xynIvwBKItsCoiaicw/AnAmfkYSBdn+Q12c/Qa60IHx/6sTJcpnFDGnK?= =?Windows-1252?Q?eDCH2kPAgsOWvvA8uL43IV+OWWmIFWG2XmfKqGpfiKn6AsSZQhPImGjQ?= =?Windows-1252?Q?I8S10TpIAUJu6uUSZGCwEgYHjRgbeLC6IHc++DTmz03EDtoIMkTV2S5a?= =?Windows-1252?Q?Yn2NJ/qBM0cJqgXyi2/9BI082ZpbAKEfSo0ao3JxanGbhgkuIkEMAoPN?= =?Windows-1252?Q?zqMjFTtI2931D9KWma0JzJF4bt0hUIe7/BfTIqGanxnEU6kCDy65UW91?= =?Windows-1252?Q?/LeDWGSmgbQIC9BE4HXcE1zLwqrBfbzRjNI+xZucvDJpCsMGDM4D7X29?= =?Windows-1252?Q?7u4Fc8+il3voU+EnLGMoFwbHNuFmwt/AHJL6yZPNgvYFWGvBx6G1WxiN?= =?Windows-1252?Q?htkXA0cz2FEmGh3jYL7tMqq1j+xCoyACYLnoIxhBwj0+/zYtwVvO/832?= =?Windows-1252?Q?ah+exh3im9qqClsJsG8o00cOwlslHUWO5ByCuHiBWs2q9UPxn+IX7V3n?= =?Windows-1252?Q?a98PHapuiCNX7tPvC1qiC0Fblk/SgHHUQMKq9gaPdD+vkEUOTq/2hmML?= =?Windows-1252?Q?vdAb5y3nChZqeldXwPqrcntd5suCpBZF4RtUUO4c7hvJG6xlphlhMWhj?= =?Windows-1252?Q?jBg9QLuHriLzzzIf+0g6KTX0L4tzFcYjuuBfxoZgBf0RbdBfJRQcIj0W?= =?Windows-1252?Q?a4ZNdUWZeqL0EICZI4GGKlWAH5iPJRL5xBPGxgwt0KOhmD3Gz6A2URjr?= =?Windows-1252?Q?UJAZvwC9lOt4G89RRItTGHiL0rTQRbpwRFFAsHmI4MqK6yLyz4YEM4lO?= =?Windows-1252?Q?dglLGJjfUTwwFUldT7m0oDJi88KIyf8nDOOVTJMs0QLaJiesVkINn05N?= =?Windows-1252?Q?LlyOYH7DdXO/DhpSwnS6HQjo89da+21ID0SYu0HXdq/W4n0+FePUq9RU?= =?Windows-1252?Q?7gArYyC3Q7Lrd4SpDcjWCYuM+1mln7TwOvqD1+4EqkACekKD6udrEwE3?= =?Windows-1252?Q?PUsD/lmuT04aWE+1CDb3EAmnjCtJFNjSak63aKA3wkj6syAYr1xewTyf?= =?Windows-1252?Q?WUU9uWXbY3EEeuvkO/9u3tf55Pk1KiPVFxQ3RIfqxNwk6mofMhxXKsfp?= =?Windows-1252?Q?QafZkffRQJaLcB04G2xJN4lzK/RFrPhbiJdSulcSgoKRfl6rHYe/jmQ6?= =?Windows-1252?Q?2yw/qAM2beVp8aZay15izIIYGuGyPseBnoajQE=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB021;3:X0u+sTyUwqTek3MwDP+75DApmGPlNkObjR1y9AITMbNfijCdWdlfFioZ6pwJ/aweXEWnl5ntc4C+NAYoJPqWfWGWYaYknmqSfi4AXZCA6wau8toNfWikYSue46DFmI9Elq7t+sNlo8eTAliG7orSUQ==;10:bf9OsJxZ6zHzS6Gw7OX25PBg6p3bNqDEXoxIaIXh7us3hSpZq618nnczv/flAf6n2iGzOk7JAvuc5WxTyPa7OifNwkZA5uQeBBIsmlpcAD4= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2015 11:25:05.5905 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB021 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2015 10:51 AM, Masahiro Yamada wrote: > This driver is tristate, so it should be cleanable. > > Signed-off-by: Masahiro Yamada > --- > > drivers/gpio/gpio-zynq.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c > index 184c4b1..1d38da7 100644 > --- a/drivers/gpio/gpio-zynq.c > +++ b/drivers/gpio/gpio-zynq.c > @@ -722,6 +722,12 @@ static int __init zynq_gpio_init(void) > } > postcore_initcall(zynq_gpio_init); > > +static void __exit zynq_gpio_exit(void) > +{ > + platform_driver_unregister(&zynq_gpio_driver); > +} > +module_exit(zynq_gpio_exit); > + > MODULE_AUTHOR("Xilinx Inc."); > MODULE_DESCRIPTION("Zynq GPIO driver"); > MODULE_LICENSE("GPL"); > Looks reasonable to me. Tested-by: Michal Simek Thanks, Michal