Re: [PATCH 3/5] vhost: support upto 509 memory regions

Paolo Bonzini
2015-06-18T10:03:44Z

On 18/06/2015 11:50, Michael S. Tsirkin wrote:
> > But lets assume that there are tools that do this so
> > how about instead of hardcoding limit make it a module parameter
> > with default set to 64. That would allow users to set higher limit
> > if they need it and nor regress old tools. it will also give tools
> > interface for reading limit from vhost module.
>
> And now you need to choose between security and functionality :(

Don't call "security" a 16K allocation that can fall back to vmalloc
please. That's an insult to actual security problems...

Paolo