From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: ext York Sun <yorksun@freescale.com>, wsa@the-dreams.de
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Paul Bolle <pebolle@tiscali.nl>,
Peter Korsgaard <peter.korsgaard@barco.com>
Subject: Re: [Patch v2] driver/i2c/mux: Add register based mux i2c-mux-reg
Date: Thu, 18 Jun 2015 14:35:43 +0200 [thread overview]
Message-ID: <5582BB1F.5050606@nokia.com> (raw)
In-Reply-To: <1434575634-27977-1-git-send-email-yorksun@freescale.com>
Hello!
On 17/06/15 23:13, ext York Sun wrote:
> + switch (mux->data.reg_size) {
> + case 4:
> + iowrite32(mux->data.values[chan], mux->data.reg);
> + break;
> + case 2:
> + iowrite16(mux->data.values[chan], mux->data.reg);
> + break;
> + case 1:
> + iowrite8(mux->data.values[chan], mux->data.reg);
> + break;
I'd like to see at least [optional] read-back operation after each write.
And if you stick with iowrite*(), maybe it desires a comment (in the Documentation/ file?),
that write will be little-Endian, therefore BE users must take care...
Other than that it looks good to me...
--
Best regards,
Alexander Sverdlin.
next prev parent reply other threads:[~2015-06-18 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 21:13 [Patch v2] driver/i2c/mux: Add register based mux i2c-mux-reg York Sun
2015-06-18 12:35 ` Alexander Sverdlin [this message]
2015-06-18 15:08 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5582BB1F.5050606@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=peter.korsgaard@barco.com \
--cc=wsa@the-dreams.de \
--cc=yorksun@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox