Re: [PATCH] fs: inotify: systemd needs it so make it depend on CONFIG_EMBEDDED

[Austin S Hemmelgarn <ahferroin7@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]

On 2015-06-19 14:18, Ilia Mirkin wrote:
> On Fri, Jun 19, 2015 at 2:07 PM, Dave Hansen <dave@sr71.net> wrote:
>>
>> From: Dave Hansen <dave.hansen@linux.intel.com>
>>
>> I have a little microbenchmark that sits and does write() in a loop.
>> The number one kernel function in the profiles is __srcu_read_lock()
>> from fsnotify().  I decided to turn off INOTIFY in order to see what
>> the potential from optimizing this path would be.  I ended up with
>> a system at the rescue console as systemd complained that dependencies
>> were not met mounting some non-root filesystems:
>>
>>          systemd: inotify_init1() failed: Function not implemented
>>          systemd: Dependency failed for Mark the need to relabel after reboot.
>>          systemd: Triggering OnFailure= dependencies of local-fs.target.
>>          systemd: inotify_init1() failed: Function not implemented
>>          systemd: Dependency failed for /gcc.
>>
>> It looks like CONFIG_INOTIFY is now a critical part of any system
>> that wants to both use systemd and boot.  Let's make it depend
>> on CONFIG_EMBEDDED.
>
> Is systemd depending on something really reason enough to make it
> depend on EMBEDDED? For example all the cgroups stuff is not only not
> dependent on embedded, but also off by default, and I'm sure there are
> a boatload of other dependencies which any normal system has no
> business worrying about but that are required by systemd.
>
>    -ilia
I agree with this, kconfig isn't designed to make sure that your system 
will boot.  There are plenty of non-embedded systems that don't use 
systemd at all (such as every Linux based system on the TOP500 list, and 
a large majority of Gentoo installations), and also have no reason to 
have INOTIFY enabled.

I would stipulate however that systemd _should_ (if it doesn't already) 
clearly document this and any other kernel configuration dependencies.



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 2967 bytes --]