From: Ian Abbott <abbotti@mev.co.uk>
To: "Abdul, Hussain (H.)" <habdul@visteon.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence
Date: Sat, 20 Jun 2015 13:40:41 +0100 [thread overview]
Message-ID: <55855F49.8080407@mev.co.uk> (raw)
In-Reply-To: <DB5PR06MB1112937A828BDC4D0D2A19ECDFA40@DB5PR06MB1112.eurprd06.prod.outlook.com>
On 19/06/15 06:59, Abdul, Hussain (H.) wrote:
>
>
> This patch simplify a trivial if-return sequence. Possibly combine with
> a preceding function call.
>
> Abdul Hussain (6):
> staging: comedi: dmm32at: Simplify a trivial if-return sequence
> staging: comedi: fl512: Simplify a trivial if-return sequence
> staging: comedi: daqboard2000: Simplify a trivial if-return sequence
> staging: comedi: dac02: Simplify a trivial if-return sequence
> staging: comedi: daq_dio24: Simplify a trivial if-return sequence
> staging: comedi: s626: Simplify a trivial if-return sequence
>
>
> drivers/staging/comedi/drivers/dac02.c | 6 +-----
> drivers/staging/comedi/drivers/daqboard2000.c | 7 +------
> drivers/staging/comedi/drivers/dmm32at.c | 6 +-----
> drivers/staging/comedi/drivers/fl512.c | 6 +-----
> drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
> drivers/staging/comedi/drivers/s626.c | 6 +-----
Looks good apart from the checkpatch warning in patch 3 as pointed out
by Sudip.
For patches 1-2 and 4-6:
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-20 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 14:03 [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence Abdul, Hussain (H.)
2015-06-19 5:59 ` Abdul, Hussain (H.)
2015-06-20 12:40 ` Ian Abbott [this message]
[not found] ` <DB5PR06MB1112DB9D7F15F4F6C2B87B0FDFA10@DB5PR06MB1112.eurprd06.prod.outlook.com>
2015-06-22 9:18 ` [PATCH v2 " Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55855F49.8080407@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=habdul@visteon.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox