From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754966AbbFTMof (ORCPT ); Sat, 20 Jun 2015 08:44:35 -0400 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:43907 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753470AbbFTMod (ORCPT ); Sat, 20 Jun 2015 08:44:33 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <5585602F.60808@mev.co.uk> Date: Sat, 20 Jun 2015 13:44:31 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Geliang Tang , hsweeten@visionengravers.com, gregkh@linuxfoundation.org CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: fix sparse warning in ni_mio_common.c References: <1434818854-19017-1-git-send-email-geliangtang@163.com> In-Reply-To: <1434818854-19017-1-git-send-email-geliangtang@163.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/06/15 17:47, Geliang Tang wrote: > This patch fixes the following sparse warning: > > drivers/staging/comedi/drivers/ni_mio_common.c:573:26: warning: shift > too big (4294967295) for type int > > Signed-off-by: Geliang Tang > --- > drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c > index 6cc304a..420f752 100644 > --- a/drivers/staging/comedi/drivers/ni_mio_common.c > +++ b/drivers/staging/comedi/drivers/ni_mio_common.c > @@ -570,7 +570,7 @@ static inline void ni_set_bitfield(struct comedi_device *dev, int reg, > static inline unsigned ni_stc_dma_channel_select_bitfield(unsigned channel) > { > if (channel < 4) > - return 1 << channel; > + return 1 << (channel & 0x03); > if (channel == 4) > return 0x3; > if (channel == 5) > Surely that's a false positive sparse warning? -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/